NetarchiveSuite|
Size: 2187
Comment:
|
Size: 2129
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 1: | Line 1: |
| #acl NetarkivetGroup:read,write,delete,revert,admin All: |
Reviews in iteration 33
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
If the reviewer for some reason cannot be contacted within a reasonable timeframe, another reviewer should be chosen.
We don't register review time as separate from coding time.
For details on how to do a review, see ["Code Review Process"].
[:Code Review Process#TableFilledReviewsOverview:Class/Page] |
[:Code Review Process#TableFilledReviewsOverview:Version] |
[:Code Review Process#TableFilledReviewsOverview:Lines/parts] |
[:Code Review Process#TableFilledReviewsOverview:Task] |
[:Code Review Process#TableFilledReviewsOverview:Author(s)] |
[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)] |
[:Code Review Process#TableFilledReviewsOverview:Review date] |
[:Code Review Process#TableFilledReviewsOverview:Follow-up] |
[:Code Review Process#TableFilledReviewsOverview:Done] |
[:CommonDistributeArcrepositoryARCLookupReview:dk.netarkivet.common.distribute.arcrepository.ARCLookup] |
212 |
147-150 |
Bug #1079 |
LC |
|
|
|
|
[:HarvesterHarvestingJMXHeritrixControllerReview:dk.netarkivet.harvester.harvesting.JMXHeritrixController] |
212 |
78-79,138-139,236,316-334 |
Bug #1182 |
LC |
|
|
|
|
[:CommonDistributeChannelsReview:dk.netarkivet.common.distribute.Channels.java] |
|
|
Bug #555 |
SVC |
|
|
|
|
[:CommonDistributeJMSConnectionReview:dk.netarkivet.common.distribute.JMSConnection] |
|
|
Bug #555 |
SVC |
|
|
|
|
[:CommonDistributeJMSConnectionSunMQReview:dk.netarkivet.common.distribute.JMSConnectionSuMQ] |
|
|
Bug #555 |
SVC |
|
|
|
|