• Iteration36ReviewsOverview

Reviews in Iteration 36
Use IterationReviewsOverviewTemplate template to start new review pages.

Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description

Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table

For details on how to do a code review, see Code Review Process.

Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode: || [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||

Document Reviews
Description of columns can be found in section Explanation of the columns in document review table.

For details on how to do Document reviews, see Document Review Process.

Template for insertion of a new line in edit mode: || [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - || Template for new document review page (under DocumentReview/): ReviewDocumentPageTemplate

Explanation of the columns in Code Review table:

• "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]

• "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
• "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
• "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
• "Review date": Date for review.
• "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
• "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.

• "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

• "Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).

• "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.

Explanation of the columns in Document Review table:

• "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].

• "Version": The SVN, CVS or date for revision of document/script to be reviewed.
• "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
• "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
• "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
• "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
• "Review date": Date for review.
• "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.

• "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.