~+'''Reviews in Iteration 36'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~

<<Anchor(CodeReViewTplCrTable)>> '''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]

For details on how to do a code review, see [[Process/Code Review|Code Review Process]].

Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Release Test''' <<BR>> ~--, incl., excl.-~ ||<bgcolor="#dddddd" style="vertical-align: top; text-align: center;">'''Manuals''' <<BR>> ~-Quick, Deploy, Conf., Inst., Dev., User-~ ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-12|NS-12]] ||Java 6 (FileUtils.GetBytesFree() ||KFC ||JOLF/SVC ||2009/02/24 ||IssuesFoundInReviewNs12 ||SVC ||OK ||Excl ||Quick ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-17|NS-17]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=662|Bug 662]] ||CSR ||SVC ||2009/03/10 ||IssuesFoundInReviewNs17 ||CSR ||OK-wp ||incl.TEST4 item18.1 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-16|NS-16]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1152|Bug 1152]] ||CSR ||SVC ||2009/02/20 ||IssuesFoundInReviewNs16 ||CSR ||OK ||incl. TEST4 item 15-16 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-19|NS-19]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=934&group_id=7&atid=105|Bug 934]] ||SVC ||JOLF ||2009/2/19 ||IssuesFoundInReviewNs19 ||SVC ||OK ||incl.TEST1 item2 ok || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-32|NS-32]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1492&group_id=7&atid=105|Bug 1492]], [[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1410|FR 1410]] ||ELZI ||JOLF || 2009/03/25 || IssuesFoundInReviewNs32 || ELZI || OK-wp ||incl. TEST3 item7 ok || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-34|NS-34]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=574&group_id=7&atid=105|Bug 574]] ||ELZI ||SVC || 2009/03/25 ||IssuesFoundInReviewNs34 || ELZI || OK-wp ||incl. in other tests (hard to test separately) || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-27|NS-27]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1193&group_id=7&atid=105|Bug 1193]], Batch Framework ||SVC ||JOLF ||2009/03/24 ||IssuesFoundInReviewNs27 ||SVC ||OK-wp ||incl.TEST11 item3 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-23|NS-23]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1497&group_id=7&atid=108|FR 1497 (Button in NetarchiveSuite)]] ||SVC ||JOLF ||2009/03/10 ||IssuesFoundInReviewNs23 ||SVC ||OK ||incl.TEST2 item13 ok ||User ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-20|NS-20]] ||[[AssignmentDeploy1|Deploy Assignment 1]] - module [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=431&group_id=7&atid=105|Bug 431]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=433&group_id=7&atid=105|Bug 433]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=846&group_id=7&atid=105|Bug 846]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1271&group_id=7&atid=105|Bug 1271]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1520&group_id=7&atid=108|FR 1520]] ||JOLF ||SVC ||2009/02/18 ||IssuesFoundInReviewsNs20 ||JOLF ||OK ||incl.TEST3 ok || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-33|NS-33]] ||[[AssignmentDeploy1|Deploy Assignment 1]] - settings, [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=291&group_id=7&atid=108|FR 291]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1488&group_id=7&atid=108|FR 1488]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1308&group_id=7&atid=105|Bug 1308]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105|Bug 1501]] ||ELZI || JOLF ||2009/03/25 ||IssuesFoundInReviewNs33 || ELZI ||OK ||incl.TEST1 item2 ok ||Quick, User, Install, Config ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-36|NS-36]] || Additional to [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-33|NS-33]] ||ELZI || JOLF ||2009/03/25 || IssuesFoundInReviewNs36 || ELZI || OK-wp ||incl.TEST1 item2 ok ||Quick, User, Install, Config ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-37|NS-37]] || Additional to [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-33|NS-33]] ||ELZI || SVC ||2009/03/25 || IssuesFoundInReviewNs37 || SVC ||OK ||incl.TEST1 item2 ok ||Quick, User, Install, Config ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-30|NS-30]] ||[[AssignmentDeploy1|Deploy Assignment 1]] - System state ||JOLF ||SVC ||2009/03/17 ||IssuesFoundInReviewNs30 ||JOLF ||OK ||incl.TEST1 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-21|NS-21]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1493&group_id=7&atid=107|Patch 1493 (German Translation)]] ||SVC ||JOLF ||2009/03/10 ||IssuesFoundInReviewNs21 ||SVC ||OK ||excl. || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-22|NS-22]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1336|Bug 1336]] ||CSR ||SVC ||2009/02/20 ||IssuesFoundInReviewNs22 ||CSR ||OK ||excl. || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-28|NS-28]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=770|FR 770]], [[http://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1146|FR 1146]], [[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1226|Bug 1226]] ||SVC ||CSR ||2009/03/19 ||IssuesFoundInReviewNs28 ||SVC ||OK ||incl.TEST1 item 6, TEST7 item 2-2.0(1226) || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-29|NS-29]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1160|FR 1160]], [[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1162|FR 1162]], ||SVC ||JOLF ||2009/03/20 ||IssuesFoundInReviewNs29 ||SVC ||OK ||incl.TEST7 item 5 || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-24|NS-24]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1485|FR 1485]] ||SVC ||JOLF ||2009/03/11 || IssuesFoundInReviewNs24 ||SVC ||OK ||incl.TEST1 item6 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-35|NS-35]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1519|Bug 1519]] ||SVC ||JOLF ||2009/03/20 ||IssuesFoundInReviewNs35 ||SVC ||OK-wp ||incl.TEST4 item6 ok || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-25|NS-25]] ||Review of FileUtils.getResourceFileFromClassPath() ||JOLF ||SVC ||2009/02/25 ||IssuesFoundInReviewNs25 ||JOLF ||OK ||- ||- ||
||NA (no code changes) ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1252|FR 1252]](Derby Upgrade) ||SVC || || || || || ||~-incl.TEST7 item 2-2.0-~ || Install ||
||No code changes ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1266|Bug 1266]] ||ELZI || || || || || || || User ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-31|NS-31]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1564|Bug 1564]] ||SVC ||JOLF || 2009/03/19 || IssuesFoundInReviewNs31 ||SVC ||OK || incl.TEST12 || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-38|NS-38]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1566|Bug 1566]] ||SVC ||JOLF ||2009/04/16 || IssuesFoundInReviewNs38 ||SVC ||OK || incl.TEST? || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-41|NS-41]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1613|Bug 1613]] ||SVC/JOLF ||JOLF ||2009/04/23 || IssuesFoundInReviewNs41 ||JOLF ||OK || incl.TEST1 || ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-42|NS-42]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1564|Bug 1564]] [[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1629|Bug 1629]] ||KFC ||SVC ||2009/04/30 || IssuesFoundInReviewNs42 || KFC ||OK||incl. TEST12|| ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-44|NS-44]] ||[[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1152|Bug 1152]]  || CSR || SVC || 2009/05/11 || IssuesFoundInReviewNs44 || CSR || OK || - || - ||


<<Anchor(CodeReViewTplOrTable)>> '''''Document Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in document review table]].

For details on how to do Document reviews, see [[Process/Document Review|Document Review Process]].

Template for insertion of a new line in edit mode: `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||` Template for new document review page (under `DocumentReview/`): ReviewDocumentPageTemplate
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
||[[DocumentReview/NetarchiveSuiteAssignmentDeploy1Review|http://netarchive.dk/suite/AssignmentDeploy1]] ||2008/12/15 ||All || ||ELZI ||SVC ||2008/12/16 ||ELZI ||OK-wp ||
||[[DocumentReview/NetarchiveSuiteAssignmentGroupB2Review|http://netarchive.dk/suite/AssignmentGroupB2]] ||2008/10/30 ||All || ||ELZI ||KFC ||2008/10/31 ||ELZI ||OK ||
||[[DocumentReview/NetarchiveSuiteQuickStartManualReview|https://netarchive.dk/suite/Quick_Start_Manual_devel]] ||?? ||All ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1104&group_id=7&atid=108|FR 1104]], new screen dumps ||TLR || || || || ||
||[[DocumentReview/NetarchiveSuiteConfigurationManualReview|https://netarchive.dk/suite/Configuration_Manual_devel]] ||?? ||All ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1514&group_id=7&atid=105|Bug 1514]] ||ELZI || || || || ||
||[[DocumentReview/NetarchiveSuiteInstallationManualReview|https://netarchive.dk/suite/Installation_Manual_devel]] ||?? ||All ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1484&group_id=7&atid=105|Bug 1484]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1389&group_id=7&atid=108|FR 1389]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1104&group_id=7&atid=108|FR 1104]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=281&group_id=7&atid=108|FR 281]], settings + [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1389&group_id=7&atid=108|FR 1226, ]] [[AssignmentDeploy1|Deploy Assignment 1]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105|Bug 1501]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1266&group_id=7&atid=105|Bug 1266]] ||ELZI/JOLF || || || || ||
||[[DocumentReview/NetarchiveSuiteDeveloperManualReview|https://netarchive.dk/suite/Developer_Manual_devel]] ||?? ||All ||structure ([[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1287&group_id=7&atid=108|FR 1287]]) batch ([[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1216&group_id=7&atid=105|Bug 1216]]), upload, channels ([[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1132&group_id=7&atid=105|Bug 1132]]) deduplication (task 44 in [[Iteration36TaskList|Iteration 36]]) ||ELZI/SVC ||CSR ||2009/03/18 ||CSR/JOLF/SVC/ELZI || ||
||http://netarchive.dk/suite /Deploy_Manual_devel (integrated into the Installation Manual) ||?? ||All ||[[AssignmentDeploy1|Deploy Assignment 1]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105|Bug 1501]] ||JOLF || || || || ||
||[[DocumentReview/NetarchiveSuiteUserManualReview|https://netarchive.dk/suite/User_Manual_devel]] ||?? ||All ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1178&group_id=7&atid=105|Bug 1178]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1266&group_id=7&atid=105|Bug 1266]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1178&group_id=7&atid=105|Bug 1178]], new screen dumps, Files with checksumserrors, Missing files,Harvest information for job, [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1212&group_id=7&atid=105|Bug 1212]], [[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1261&group_id=7&atid=105|Bug 1261]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1262&group_id=7&atid=105|Bug 11262]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1263&group_id=7&atid=105|Bug 1263]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1266&group_id=7&atid=105|Bug 1266]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1108&group_id=7&atid=108|FR 1108]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1497&group_id=7&atid=105|Bug 1497]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1492&group_id=7&atid=105|Bug 1492]],[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1410&group_id=7&atid=105|Bug 1410]] ||CLO || || || || ||
||[[DocumentReview/NetarchiveSuiteBugInfGuideReview|http://netarchive.dk/suite/BugInfGuide]] ||2009/02/10 ||All ||Task 2+3 in [[Iteration36TaskList|Iteration 36]] ||ELZI || || || || ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
<<Anchor(CodeReViewTplOrColumns)>> '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.