6227
Comment:
|
6234
|
Deletions are marked like this. | Additions are marked like this. |
Line 1: | Line 1: |
~+'''Reviews in Iteration 37'''+~[[BR]] ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~ |
~+'''Reviews in Iteration 37'''+~[[BR]] ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~ |
Line 4: | Line 3: |
Contains: ~-[#CodeReViewTplCrTable Code Review Table]-~, ~-[#CodeReViewTplOrTable Document Review Table]-~, ~-[#CodeReViewTplCrColumns Code Review Column Description]-~, ~-[#CodeReViewTplOrColumns Document Review Column Description]-~ [[Anchor(CodeReViewTplCrTable)]] '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code_Review:Code Review Process]. [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||` |
Contains: ~-[#CodeReViewTplCrTable Code Review Table]-~, ~-[#CodeReViewTplOrTable Document Review Table]-~, ~-[#CodeReViewTplCrColumns Code Review Column Description]-~, ~-[#CodeReViewTplOrColumns Document Review Column Description]-~ [[Anchor(CodeReViewTplCrTable)]] ''''' ''''' '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code Review:Code Review Process]. [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||` |
Line 14: | Line 9: |
[[Anchor(CodeReViewTplOrTable)]] '''''Document Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document_Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||` |
[[Anchor(CodeReViewTplOrTable)]] '''''Document Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||` |
Line 22: | Line 14: |
[[Anchor(CodeReViewTplCrColumns)]] '''''Explanation of the columns in Code Review table:''''' |
[[Anchor(CodeReViewTplCrColumns)]] '''''Explanation of the columns in Code Review table:''''' |
Line 33: | Line 27: |
* "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [:Quick Start Manual devel: Quick Start Manual], "'''Deploy'''" for [:Deploy Manual devel: Deploy Manual], "'''Conf.'''" for [:Configuration Manual devel: Configuration Manual], "'''Inst..'''" for [:Installation Manual devel: Installation Manual], "'''Dev.'''" for [:Developer Manual devel: Developer Manual], "'''User'''" for [:User Manual devel: User Manual]. [[Anchor(CodeReViewTplOrColumns)]] '''''Explanation of the columns in Document Review table:''''' |
* "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [:Quick Start Manual devel:Quick Start Manual], "'''Deploy'''" for [:Deploy Manual devel:Deploy Manual], "'''Conf.'''" for [:Configuration Manual devel:Configuration Manual], "'''Inst..'''" for [:Installation Manual devel:Installation Manual], "'''Dev.'''" for [:Developer Manual devel:Developer Manual], "'''User'''" for [:User Manual devel:User Manual]. [[Anchor(CodeReViewTplOrColumns)]] '''''Explanation of the columns in Document Review table:''''' |
Reviews in Iteration 37BR Use IterationReviewsOverviewTemplate template to start new review pages.
Contains: [#CodeReViewTplCrTable Code Review Table], [#CodeReViewTplOrTable Document Review Table], [#CodeReViewTplCrColumns Code Review Column Description], [#CodeReViewTplOrColumns Document Review Column Description] Anchor(CodeReViewTplCrTable)
Code ReviewsBR Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. BR For details on how to do a code review, see [:Process/Code Review:Code Review Process]. BR Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] BR Template for insertion of a new line in edit mode: BR || [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||
Review Id BR NS-XX |
Task BR Bug/FR XXX |
Author(s)BR INIT |
Reviewer(s) BR INIT |
Review date BR YYYY/MM/DD |
Issues found BR IssuesFromNsXX |
Follow-up BR INIT |
Done BR -, OK, OK-wp |
NS-XX |
Bug/FR XXX |
INIT |
INIT |
YYYY/MM/DD |
IssuesFromNsXX |
INIT |
- |
Anchor(CodeReViewTplOrTable) Document ReviewsBR Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].BR For details on how to other reviews, see [:Process/Document Review:Document Review Process].BR Template for insertion of a new line in edit mode:BR || [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
Document BR [:link:docName] |
Version BR X.Y/date |
Lines/parts BR All/x-y |
Task BR Bug/FR XXX |
Author(s)BR INIT |
Reviewer(s) BR INIT |
Review date BR YYYY/MM/DD |
Follow-up BR INIT |
Done BR -, OK, OK-wp |
Version |
Lines |
Bug/FR XXX |
INIT |
INIT |
YYYY/MM/DD |
INIT |
- |
Anchor(CodeReViewTplCrColumns) Explanation of the columns in Code Review table:
"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for [:Quick Start Manual devel:Quick Start Manual], "Deploy" for [:Deploy Manual devel:Deploy Manual], "Conf." for [:Configuration Manual devel:Configuration Manual], "Inst.." for [:Installation Manual devel:Installation Manual], "Dev." for [:Developer Manual devel:Developer Manual], "User" for [:User Manual devel:User Manual].
Anchor(CodeReViewTplOrColumns) Explanation of the columns in Document Review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.