~+'''Reviews in Iteration 37'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~ <<Anchor(CodeReViewTplCrTable)>> ''''' '''''''''''

'''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>> For details on how to do a code review, see [[Process/Code Review|Code Review Process]].  <<BR>> Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: <<BR>> `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||- ||- ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-43|NS-43]] || FR 1654 || Andreas || SVC ||2009/06/19 || IssuesFromNs43 ||Andreas || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-44|NS-44]] || Bug 1152 (reopened) || CSR || SVC || 2009/05/11 || IssuesFromNs44 || CSR || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-45|NS-45]] || FR 1628 || N.Giraud || SVC || 2009/06/11 || IssuesFromNs45 ||NGIRAUD || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-46|NS-46]] || Bug 1694 || N.Giraud || SVC || 2009/06/11 || IssuesFromNs46 ||NGIRAUD || OK || incl TEST1F? ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-47|NS-47]] || Bug 1254 || N.Giraud || SVC ||2009/06/11 || IssuesFromNs47 ||NGIRAUD || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-48|NS-48]] || Bug 1611, 1636, 1646 || SVC ||JOLF ||2009/07/23 || IssuesFromNs48 ||SVC ||OK ||No changes neeeded to releasetest ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-49|NS-49]] || FR 1675 || Andreas || SVC ||2009/06/19 || IssuesFromNs49 ||Andreas || OK ||incl TEST1 item 4 ? ||QuickStart, UserManual ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-50|NS-50]] || Bug 1711 || KFC || CSR ||2009/06/30 || IssuesFromNs50 ||KFC || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-51|NS-51]] || Bug 1336 || KFC || HBK || -- || IssuesFromNs51 || -- || - ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-52|NS-52]] || Bug 1188 ||CSR || JOLF || 2009/08/26 || IssuesFromNs52 ||CSR ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-53|NS-53]] || Bug 1188, 1174, 1661 ||CSR || JOLF || 2009/08/26 || IssuesFromNs53 ||CSR ||OK-wp ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-54|NS-54]] || Abandoned || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-55|NS-55]] || Bug 928 || HBK || SVC ||2009/07/14 || IssuesFromNs55 ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-56|NS-56]] || Abandoned || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-57|NS-57]] || FR 1014 || HBK || SVC ||2009/07/08 || IssuesFromNs57 ||HBK ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-58|NS-58]] || Handled in NS-55 || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-59|NS-59]] || OBSOLETE,See NS-63 || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-60|NS-60]] || FR 1709 ||Andreas || SVC,HBK || 2009/07/28 || IssuesFromNs60 || Andreas,SVC || OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-61|NS-61]] || FR 1716-1717, Bug 1644 || SVC ||JOLF || 2009/07/23 || IssuesFromNs61 ||SVC ||OK ||Releasetest, that uses template download pages should  verify that these bugs are verified ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-62|NS-62]] || Abandoned || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-63|NS-63]] || Bug 1650 || Elenora* || HBK, JOLF ||2009/07/28 || IssuesFromNs63 ||JOLF ||OK ||Try removing one of the jmxremote files, and check that the correct error occurs. ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-64|NS-64]] || Bug 1670 || KFC* || JOLF, SVC || 2009/07/22 || No issues || -- || OK || Releasetest? || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-65|NS-65]] || Bug 555 and related ||KFC* ||SVC,HBK ||2009/07/29 || IssuesFromNs65 ||SVC ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-66|NS-66]] || Abandoned || - || - || - || - ||-- ||- ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-67|NS-67]] || Bug 1722: Excessive logging in indexserver ||KFC* ||JOLF,SVC ||2009/07/22 || No issues || -- ||OK ||No ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-68|NS-68]] || Bug 1078 + 1079 || JOLF || SVC || 2009/07/22 || No issues || -- || OK || Releasetest? || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-69|NS-69]] || Bug 1547: Wrong synchronization ... ||KFC* || SVC,JOLF ||2009/07/22 || No issues ||-- ||OK ||Releasetest? ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-70|NS-70]] || Bug 1718: The link to monitor Heritrix process .. ||KFC* || JOLF,SVC ||2009/07/22 || No issues ||-- ||OK ||Releasetest? ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-71|NS-71]] || Bug 1712: Starting multiple applications .. ||KFC* || JOLF,SVC ||2009/07/22 || IssuesFromNs71 ||JOLF ||OK ||Run several viewerproxy applications on a single machine. ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-72|NS-72]] || Bug 1700: The WebProxy.handle() method creates CreateErrorResponse for null Uri ||KFC* || JOLF,SVC ||2009/07/22 || No issues ||-- ||OK ||Releasetest? ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-73|NS-73]] || Bug 1702 || N.Giraud* || JOLF, SVC ||2009/07/28 || IssuesFromNs73 ||SVC ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-74|NS-74]] || FR 1723 (Upgrade of Heritrix templates) || SVC || JOLF ||2009/07/30 || No issues || -- || OK || Releasetest? || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-75|NS-75]] || FR 1040 (2nd review) || HBK || SVC ||2009/08/05 || IssuesFromNs75 || HBK || OK || Special releasetest || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-78|NS-78]] || Wayback Ant Tasks || CSR || JOLF ||2009/08/26 || IssuesFromNs78 || CSR ||OK ||New Release Test required ?|| - ||


''Authors'' marked with ''*'' have not been part of the review

<<Anchor(CodeReViewTplOrTable)>> '''''Document Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>> For details on how to other reviews, see [[Process/Document Review|Document Review Process]].<<BR>> Template for insertion of a new line in edit mode:<<BR>> `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - || - || - ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and  "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
<<Anchor(CodeReViewTplOrColumns)>> '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.