~+'''Reviews in Iteration 38'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~

<<Anchor(CodeReViewTplCrTable)>>  '''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>> For details on how to do a code review, see [[Process/Code Review|Code Review Process]].  <<BR>> Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: <<BR>> `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-51|NS-51]] || Bug 1336 || KFC || HBK || Rejected || IssuesFromNs51 || || ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-52|NS-52]] || Bug 1188 ||CSR || JOLF || 2009/07/27 || IssuesFromNs52 ||CSR ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-53|NS-53]] || Bug 1188, 1174, 1661 ||CSR || JOLF || 2009/07/28 || IssuesFromNs53 ||CSR ||OK ||- ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-76|NS-76]] || Bug 1073 || HBK || SVC ||2009/09/04 || IssuesFromNs76 ||ok ||ok || TEST6.13 ||- ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-79|NS-79]] || FR 1511 || HBK || KFC || 2009/09/05 || IssuesFromNs79 || ok || ok || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-80|NS-80]] || FR 1721 || HBK || SVC || 2009/09/05 || IssuesFromNs80 || ok || ok || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-81|NS-81]] || Bug 1730 || KFC || JOLF ||2009/09/25 || IssuesFromNs81 || No comments || ok || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-82|NS-82]] || Bug 1729 || KFC || SVC ||2009/09/03 || IssuesFromNs82 || KFC || OK || None needed || None needed ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-83|NS-83]] || Bug 555 || KFC || SVC ||2009/09/03 || IssuesFromNs83 ||KFC ||OK || Sent in mail || None needed ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-85|NS-85]] || FR 1298 || KFC || SVC || || IssuesFromNs85 || KFC || OK || Sent in mail || Needs update in configuration manual for new setting introduced after review ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-86|NS-86]] || Bug 1547 || KFC || SVC ||2009/09/02 || IssuesFromNs86 || KFC || OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-87|NS-87]] ||[[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1678|FR 1678]] || CSR || SVC ||2009/09/04 || IssuesFromNs87 || CSR ||OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-88|NS-88]] ||[[AssignmentGroupB2|Assignment B.2.2a]] - Generalise replica to include all checksum voters || JOLF ||KFC || 2009/09/29 || IssuesFromNs88 ||JOLF||Ok-wp || TEST1, TEST3 || [[Installation Manual 3.10|Installation Manual]]: update of deploy config xml's ;[[System Design 3.10|System Design Manual]] 5. Detailed Archive Design Description; [[User Manual 3.10|User Manual]] 10. System State ?,11. Bit Preservation; [[Additional Tools Manual 3.10|Additional Tools Manual]]: 5.6. dk.netarkivet.archive.tools.RunBatch ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-89|NS-89]] || FR 1641 || SVC || Nicolas ||2009/09/18 || IssuesFromNs89 || SVC || OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-92|NS-92]] || FR 1689 || Nicolas || SVC ||2009/09/18 || IssuesFromNs92 ||Nicolas || OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-97|NS-97]] || FR 1691 || Nicolas || SVC ||2009/09/30 || IssuesFromNs97 ||Nicolas ||OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-96|NS-96]] || FR 1750 || Eleonora || SVC ||2009/09/30 || IssuesFromNs96 ||Eleonora/SVC ||OK || - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-98|NS-98]] || FR 1660 || JOLF || KFC || 2009/09/30 || IssuesFromNs98 ||JOLF||OK-wp|| - || - ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-99|NS-99]] || FR 1767 || KFC || HBK || 2009/10/02 || IssuesFromNs99 ||KFC|| OK || Rerun TEST5 || None needed ||


<<Anchor(CodeReViewTplOrTable)>>   '''''Document Reviews'''''<<BR>>  Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>> For details on how to other reviews, see [[Process/Document Review|Document Review Process]].<<BR>> Template for insertion of a new line in edit mode:<<BR>> `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || [[AssignmentGroupB2|Assignment B.2.2a]] - Generalise replica to include all checksum voters || JOLF || || || || [[Installation Manual 3.10|Installation Manual]]: update of deploy config xml's ;[[System Design 3.10|System Design Manual]] 5. Detailed Archive Design Description; [[User Manual 3.10|User Manual]] 10. System State ?,11. Bit Preservation; [[Additional Tools Manual 3.10|Additional Tools Manual]]: 5.6. dk.netarkivet.archive.tools.RunBatch ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || How to verify Bug 1547 || TLR || || || || [[Installation Manual 3.10|Installation Manual]]: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || New deploy for Quickstart || TLR || || || || [[Quick Start Manual 3.10|Quick Start Manual]] Configuration, Viewing the results  ; [[Installation Manual 3.10|Installation Manual]] 10. Easy Installation of NetarchiveSuite ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and  "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
<<Anchor(CodeReViewTplOrColumns)>>  '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.