Diff for "Iteration39ReviewsOverview"

Differences between revisions 18 and 19

Reviews in Iteration 39BR Use IterationReviewsOverviewTemplate template to start new review pages.

Contains: [#CodeReViewTplCrTable Code Review Table], [#CodeReViewTplOrTable Document Review Table], [#CodeReViewTplCrColumns Code Review Column Description], [#CodeReViewTplOrColumns Document Review Column Description]

Anchor(CodeReViewTplCrTable) Code ReviewsBR Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. BR For details on how to do a code review, see [:Process/Code Review:Code Review Process]. BR Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] BR Template for insertion of a new line in edit mode: BR || [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||

Review Id BR NS-XX	Task BR Bug/FR XXX	Author(s)BR INIT	Reviewer(s) BR INIT	Review date BR YYYY/MM/DD	Issues found BR IssuesFromNsXX	Follow-up BR INIT	Done BR -, OK, OK-wp	Releasetest BR excl. or incl. TEST case.item and status	Manuals BR Manual page(s)/chapter(s)
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-100 NS-100]	Bug 1705	JOLF	HBK	2009/10/21	IssuesFromNs100	JOLF	OK	Run the installation scripts twice, and look for any ssh or scp errors.	No
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-101 NS-101]	FR 1745	JOLF	HBK	2009/10/21	IssuesFromNs101	JOLF	OK	Run Deploy with a configuration file where the environment name is set to 'E*R_R?O=R'. It should fail.	Installation manual (add to limitations)
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-102 NS-102]	FR 1751	JOLF	HBK	2009/10/21	IssuesFromNs102	JOLF	OK	On a running installation, run the local 'restart' script on some machines and verify that the bitapps restart in the System overview without any errors	Installation manual.
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-103 NS-103]	FR 1733	JOLF	HBK	2009/10/21	No issues.	N/A	OK	Run a batchjob, which reads system properties. It should be allowed. Need more info here....	Perhaps Additional Tools Manual.
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-104 NS-104]	FR 1765	Nicolas	SVC	YYYY/MM/DD	IssuesFromNs104	??	-	-	-
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-90 NS-90]	Bug 1771	SVC	HBK	YYYY/MM/DD	IssuesFromNs90	??	-	-	-
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-105 NS-105]	Bug 749	HBK	SVC	2009/10/20	IssuesFromNs105	HBK	OK	-	-
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-106 NS-106]	Bug 1758	CSR	HBK	2009/10/20	IssuesFromNs106	CSR	OK	-	-
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-108 NS-108]	Changes from work on Assignment B2.2	JOLF	CSR	YYYY/MM/DD	IssuesFromNs108	-	-	-	-

Anchor(CodeReViewTplOrTable) Document ReviewsBR Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].BR For details on how to other reviews, see [:Process/Document Review:Document Review Process].BR Template for insertion of a new line in edit mode:BR || [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||

Document BR `[:link:docName]`	Version BR X.Y/date	Lines/parts BR All/x-y	Task BR Bug/FR XXX	Author(s)BR INIT	Reviewer(s) BR INIT	Review date BR YYYY/MM/DD	Follow-up BR INIT	Done BR -, OK, OK-wp
[:DocumentReview/DocNameIdReview:DocName]	Version	Lines	Bug/FR XXX	INIT	INIT	YYYY/MM/DD	INIT	-

Anchor(CodeReViewTplCrColumns) Explanation of the columns in Code Review table:

"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for [:Quick Start Manual devel:Quick Start Manual], "Deploy" for [:Deploy Manual devel:Deploy Manual], "Conf." for [:Configuration Manual devel:Configuration Manual], "Inst.." for [:Installation Manual devel:Installation Manual], "Dev." for [:Developer Manual devel:Developer Manual], "User" for [:User Manual devel:User Manual].

Reviews in Iteration 39BR Use IterationReviewsOverviewTemplate template to start new review pages.

Review Id BR NS-XX

Task BR Bug/FR XXX

Author(s)BR INIT

Reviewer(s) BR INIT

Review date BR YYYY/MM/DD

Issues found BR IssuesFromNsXX

Follow-up BR INIT

Done BR -, OK, OK-wp

Releasetest BR excl. or incl. TEST case.item and status

Manuals BR Manual page(s)/chapter(s)

Document BR `[:link:docName]`	Version BR X.Y/date	Lines/parts BR All/x-y	Task BR Bug/FR XXX	Author(s)BR INIT	Reviewer(s) BR INIT	Review date BR YYYY/MM/DD	Follow-up BR INIT	Done BR -, OK, OK-wp
[:DocumentReview/DocNameIdReview:DocName]	Version	Lines	Bug/FR XXX	INIT	INIT	YYYY/MM/DD	INIT	-
[:DocumentReview/DocNameIdReview:DocName]	Version	Lines	[:AssignmentGroupB2:Assignment B.2.2a] - Generalise replica to include all checksum voters	JOLF				[:Installation Manual 3.10:Installation Manual]: update of deploy config xml's ;[:System Design 3.10:System Design Manual] 5. Detailed Archive Design Description; [:User Manual 3.10:User Manual] 10. System State ?,11. Bit Preservation; [:Additional Tools Manual 3.10:Additional Tools Manual]: 5.6. dk.netarkivet.archive.tools.RunBatch
[:DocumentReview/DocNameIdReview:DocName]	Version	Lines	How to verify Bug 1547	TLR				[:Installation Manual 3.10:Installation Manual]: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting
[:DocumentReview/DocNameIdReview:DocName]	Version	Lines	New deploy for Quickstart	TLR				[:Quick Start Manual 3.10:Quick Start Manual] Configuration, Viewing the results ; [:Installation Manual 3.10:Installation Manual] 10. Easy Installation of NetarchiveSuite

Anchor(CodeReViewTplCrColumns) Explanation of the columns in Code Review table:

"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for [:Quick Start Manual devel:Quick Start Manual], "Deploy" for [:Deploy Manual devel:Deploy Manual], "Conf." for [:Configuration Manual devel:Configuration Manual], "Inst.." for [:Installation Manual devel:Installation Manual], "Dev." for [:Developer Manual devel:Developer Manual], "User" for [:User Manual devel:User Manual].

Anchor(CodeReViewTplOrColumns) Explanation of the columns in Document Review table:

"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
"Version": The SVN, CVS or date for revision of document/script to be reviewed.
"Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

Anchor(CodeReViewTplOrColumns) Explanation of the columns in Document Review table:

"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
"Version": The SVN, CVS or date for revision of document/script to be reviewed.
"Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

-  ⇤ ← Revision 18 as of 2009-10-22 08:52:59 → 
  Size: 15479
  Editor: JonasFrellesen
  Comment:
+   ← Revision 19 as of 2009-10-22 09:08:47 → ⇥
  Size: 15395
  Editor: TueLarsen
  Comment:
-Deletions are marked like this.
+Additions are marked like this.
 Line 5:
-[[Anchor(CodeReViewTplCrTable)]]  '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code Review:Code Review Process].  [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' [[BR]] ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' [[BR]] ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' [[BR]] excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' [[BR]] Manual page(s)/chapter(s) ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-100 NS-100] || Bug 1705 || JOLF || HBK || 2009/10/21 || IssuesFromNs100 || JOLF || OK || Run the installation scripts twice, and look for any ssh or scp errors. || No ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-101 NS-101] || FR 1745 || JOLF || HBK || 2009/10/21 || IssuesFromNs101 || JOLF || OK || Run Deploy with a configuration file where the environment name is set to 'E*R_R?O=R'. It should fail. || Installation manual (add to limitations) ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-102 NS-102] || FR 1751 || JOLF || HBK || 2009/10/21 || IssuesFromNs102 || JOLF || OK || On a running installation, run the local 'restart' script on some machines. || Installation manual. ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-103 NS-103] || FR 1733 || JOLF || HBK || 2009/10/21 || No issues. || N/A || OK || Run a batchjob, which reads system properties. It should be allowed. || Perhaps Additional Tools Manual. ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-104 NS-104] || FR 1765 || Nicolas || SVC || YYYY/MM/DD || IssuesFromNs104 || ?? || - || - || - ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-90 NS-90] || Bug 1771 || SVC || HBK || YYYY/MM/DD || IssuesFromNs90 || ?? || - || - || - ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-105 NS-105] || Bug 749 || HBK || SVC || 2009/10/20 || IssuesFromNs105 || HBK || OK || - || - ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-106 NS-106] || Bug 1758 || CSR || HBK || 2009/10/20 || IssuesFromNs106 ||CSR ||OK || - || - ||
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-108 NS-108] || Changes from work on Assignment B2.2 || JOLF || CSR || YYYY/MM/DD || IssuesFromNs108 || - || - || - || - ||
+[[Anchor(CodeReViewTplCrTable)]] '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code Review:Code Review Process]. [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
-Line 17:
+Line 7:
+||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review Id''' [[BR]] ~-NS-XX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' [[BR]] ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Releasetest''' [[BR]] excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Manuals''' [[BR]] Manual page(s)/chapter(s) ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-100 NS-100] ||Bug 1705 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs100 ||JOLF ||OK ||Run the installation scripts twice, and look for any ssh or scp errors. ||No ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-101 NS-101] ||FR 1745 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs101 ||JOLF ||OK ||Run Deploy with a configuration file where the environment name is set to 'E*R_R?O=R'. It should fail. ||Installation manual (add to limitations) ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-102 NS-102] ||FR 1751 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs102 ||JOLF ||OK ||On a running installation, run the local 'restart' script on some machines and verify that the bitapps restart in the System overview without any errors ||Installation manual. ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-103 NS-103] ||FR 1733 ||JOLF ||HBK ||2009/10/21 ||No issues. ||N/A ||OK ||Run a batchjob, which reads system properties. It should be allowed. Need more info here.... ||Perhaps Additional Tools Manual. ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-104 NS-104] ||FR 1765 ||Nicolas ||SVC ||YYYY/MM/DD ||IssuesFromNs104 ||?? ||- ||- ||- ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-90 NS-90] ||Bug 1771 ||SVC ||HBK ||YYYY/MM/DD ||IssuesFromNs90 ||?? ||- ||- ||- ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-105 NS-105] ||Bug 749 ||HBK ||SVC ||2009/10/20 ||IssuesFromNs105 ||HBK ||OK ||- ||- ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-106 NS-106] ||Bug 1758 ||CSR ||HBK ||2009/10/20 ||IssuesFromNs106 ||CSR ||OK ||- ||- ||
||[http://kb-prod-udv-001.kb.dk:8060/cru/NS-108 NS-108] ||Changes from work on Assignment B2.2 ||JOLF ||CSR ||YYYY/MM/DD ||IssuesFromNs108 ||- ||- ||- ||- ||
[[Anchor(CodeReViewTplOrTable)]] '''''Document Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
-Line 18:
+Line 19:
-[[Anchor(CodeReViewTplOrTable)]]   '''''Document Reviews'''''[[BR]]  Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
+||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
||[:DocumentReview/DocNameIdReview:DocName] ||Version ||Lines ||Bug/FR XXX ||INIT ||INIT ||YYYY/MM/DD ||INIT ||- ||
-Line 33:
+Line 31:
- * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and  "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
+ * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
-Line 39:
+Line 37:
-[[Anchor(CodeReViewTplCrTable)]]  '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code Review:Code Review Process].  [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' [[BR]] ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' [[BR]] ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' [[BR]] excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' [[BR]] Manual page(s)/chapter(s) ||
+[[Anchor(CodeReViewTplCrTable)]] '''''Code Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]] For details on how to do a code review, see [:Process/Code Review:Code Review Process]. [[BR]] Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]] Template for insertion of a new line in edit mode: [[BR]] `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
-Line 42:
+Line 39:
+||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review Id''' [[BR]] ~-NS-XX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' [[BR]] ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Releasetest''' [[BR]] excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Manuals''' [[BR]] Manual page(s)/chapter(s) ||
[[Anchor(CodeReViewTplOrTable)]] '''''Document Reviews'''''[[BR]] Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
-Line 43:
+Line 42:
-[[Anchor(CodeReViewTplOrTable)]]   '''''Document Reviews'''''[[BR]]  Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]] For details on how to other reviews, see [:Process/Document Review:Document Review Process].[[BR]] Template for insertion of a new line in edit mode:[[BR]] `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || [:AssignmentGroupB2:Assignment B.2.2a] - Generalise replica to include all checksum voters || JOLF || || || || [:Installation Manual 3.10:Installation Manual]: update of deploy config xml's ;[:System Design 3.10:System Design Manual] 5. Detailed Archive Design Description; [:User Manual 3.10:User Manual] 10. System State ?,11. Bit Preservation; [:Additional Tools Manual 3.10:Additional Tools Manual]: 5.6. dk.netarkivet.archive.tools.RunBatch ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || How to verify Bug 1547 || TLR || || || || [:Installation Manual 3.10:Installation Manual]: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || New deploy for Quickstart || TLR || || || || [:Quick Start Manual 3.10:Quick Start Manual] Configuration, Viewing the results  ; [:Installation Manual 3.10:Installation Manual] 10. Easy Installation of NetarchiveSuite ||
+||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
||[:DocumentReview/DocNameIdReview:DocName] ||Version ||Lines ||Bug/FR XXX ||INIT ||INIT ||YYYY/MM/DD ||INIT ||- ||
||[:DocumentReview/DocNameIdReview:DocName] ||Version ||Lines ||[:AssignmentGroupB2:Assignment B.2.2a] - Generalise replica to include all checksum voters ||JOLF || || || ||[:Installation Manual 3.10:Installation Manual]: update of deploy config xml's ;[:System Design 3.10:System Design Manual] 5. Detailed Archive Design Description; [:User Manual 3.10:User Manual] 10. System State ?,11. Bit Preservation; [:Additional Tools Manual 3.10:Additional Tools Manual]: 5.6. dk.netarkivet.archive.tools.RunBatch ||
||[:DocumentReview/DocNameIdReview:DocName] ||Version ||Lines ||How to verify Bug 1547 ||TLR || || || ||[:Installation Manual 3.10:Installation Manual]: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting ||
||[:DocumentReview/DocNameIdReview:DocName] ||Version ||Lines ||New deploy for Quickstart ||TLR || || || ||[:Quick Start Manual 3.10:Quick Start Manual] Configuration, Viewing the results ; [:Installation Manual 3.10:Installation Manual] 10. Easy Installation of NetarchiveSuite ||
-Line 61:
+Line 57:
- * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and  "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
+ * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
-Line 63:
+Line 59:
-[[Anchor(CodeReViewTplOrColumns)]]  '''''Explanation of the columns in Document Review table:'''''
+[[Anchor(CodeReViewTplOrColumns)]] '''''Explanation of the columns in Document Review table:'''''
-Line 74:
+Line 70:
-[[Anchor(CodeReViewTplOrColumns)]]  '''''Explanation of the columns in Document Review table:'''''
+[[Anchor(CodeReViewTplOrColumns)]] '''''Explanation of the columns in Document Review table:'''''