~+'''Reviews in Iteration 39'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~

<<Anchor(CodeReViewTplCrTable)>> '''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>> For details on how to do a code review, see [[Process/Code Review|Code Review Process]]. <<BR>> Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: <<BR>> `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-100|NS-100]] ||Bug 1705 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs100 ||JOLF ||OK ||Run the installation scripts twice, and look for any ssh or scp errors. ||No ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-101|NS-101]] ||FR 1745 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs101 ||JOLF ||OK ||Run Deploy with a configuration file where the environment name is set to 'E*R_R?O=R'. It should fail. ||Installation manual (add to limitations) ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-102|NS-102]] ||FR 1751 ||JOLF ||HBK ||2009/10/21 ||IssuesFromNs102 ||JOLF ||OK ||On a running installation, run the local 'restart' script on some machines and verify that the bitapps restart in the System overview without any errors ||Installation manual. ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-103|NS-103]] ||FR 1733 ||JOLF ||HBK ||2009/10/21 ||No issues. ||N/A ||OK ||Run a batchjob, which reads system properties. It should be allowed. Need more info here.... ||Perhaps Additional Tools Manual. ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-104|NS-104]] ||FR 1765 ||Nicolas ||SVC ||2009/10/19 ||IssuesFromNs104 ||Nicolas ||OK ||- ||- ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-90|NS-90]] ||Bug 1771 ||SVC ||HBK ||2009/10/21 ||IssuesFromNs90 ||- ||OK ||- ||- ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-105|NS-105]] ||Bug 749 ||HBK ||SVC ||2009/10/20 ||IssuesFromNs105 ||HBK ||OK ||TEST5 item 6 ||- ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-106|NS-106]] ||Bug 1758 ||CSR ||HBK ||2009/10/20 ||IssuesFromNs106 ||CSR ||OK ||- ||- ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-107|NS-107]] ||FR 1776 ||Andreas ||CSR ||2009/10/23 ||No issues. ||N/A ||OK ||- ||Configuration Manual 3.10 ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-108|NS-108]] ||Changes from work on Assignment B2.2 ||JOLF ||SVC ||2009/10/23 ||IssuesFromNs108 ||JOLF ||OK ||These changes are tested in current selected tests. ||Not yet. ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-109|NS-109]] ||Assignment 2.3 ||HBK ||CSR ||2009/10/?? ||IssuesFromNs109 ||HBK ||OK ||- ||- ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-110|NS-110]] ||Bug 1712 ||KFC ||SVC ||2009/10/22 ||IssuesFromNs110 ||- ||OK ||Not possible ||None needed ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-111|NS-111]] ||Added logging to startup notice concerning where the bitarchive ||HBK ||JOLF ||2009/10/22 ||IssuesFromNs111 ||HBK ||OK ||None ||None ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-112|NS-112]] ||Bug 1770 ||KFC ||SVC ||2009/10/23 ||IssuesFromNs112 ||- ||OK ||None ||None ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-113|NS-113]] ||FR 1759 a.o ||SVC ||HBK ||2009/10/23 ||IssuesFromNs113 ||SVC || OK || || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-114|NS-114]] ||FR 1773 ||CSR ||SVC ||2009/10/30 ||IssuesFromNs114 ||CSR ||OK || ||User Manual ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-115|NS-115]] ||Assigment 2.3 test ||HBK ||JOLF ||2009/10/26 ||IssuesFromNs115 || HBK || OK || None || Quickstart ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-116|NS-116]] ||Wayback deply ||HBK ||CSR ||2009/??/?? ||IssuesFromNs116 || HBK || OK ||Test12 || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-117|NS-117]] ||Bug 1786 ||SVC ||JOLF ||2009/10/28 ||IssuesFromNs117 ||SVC ||OK || || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-119|NS-119]] ||FR 1687 French translation ||Nicolas ||CSR ||2009/10/28 ||IssuesFromNs119 ||Nicolas ||OK || || ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-120|NS-120]] ||Bug 1793 ||KFC ||SVC ||2009/11/11 ||IssuesFromNs120 ||- ||OK || ||System design, section 'Settings' ||


<<Anchor(CodeReViewTplOrTable)>> '''''Document Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>> For details on how to other reviews, see [[Process/Document Review|Document Review Process]].<<BR>> Template for insertion of a new line in edit mode:<<BR>> `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
||[[DocumentReview/DocNameIdReview|DocName]] ||Version ||Lines ||Bug/FR XXX ||INIT ||INIT ||YYYY/MM/DD ||INIT ||- ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
~+'''Reviews in Iteration 39'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~

<<Anchor(CodeReViewTplCrTable)>> '''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>> For details on how to do a code review, see [[Process/Code Review|Code Review Process]]. <<BR>> Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: <<BR>> `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||


<<Anchor(CodeReViewTplOrTable)>> '''''Document Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>> For details on how to other reviews, see [[Process/Document Review|Document Review Process]].<<BR>> Template for insertion of a new line in edit mode:<<BR>> `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
||[[DocumentReview/DocNameIdReview|DocName]] ||Version ||Lines ||Bug/FR XXX ||INIT ||INIT ||YYYY/MM/DD ||INIT ||- ||
||[[DocumentReview/DocNameIdReview|DocName]] ||Version ||Lines ||[[AssignmentGroupB2|Assignment B.2.2a]] - Generalise replica to include all checksum voters ||JOLF || || || ||[[Installation Manual 3.10|Installation Manual]]: update of deploy config xml's ;[[System Design 3.10|System Design Manual]] 5. Detailed Archive Design Description; [[User Manual 3.10|User Manual]] 10. System State ?,11. Bit Preservation; [[Additional Tools Manual 3.10|Additional Tools Manual]]: 5.6. dk.netarkivet.archive.tools.RunBatch ||
||[[DocumentReview/DocNameIdReview|DocName]] ||Version ||Lines ||How to verify Bug 1547 ||TLR || || || ||[[Installation Manual 3.10|Installation Manual]]: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting ||
||[[DocumentReview/DocNameIdReview|DocName]] ||Version ||Lines ||New deploy for Quickstart ||TLR || || || ||[[Quick Start Manual 3.10|Quick Start Manual]] Configuration, Viewing the results ; [[Installation Manual 3.10|Installation Manual]] 10. Easy Installation of NetarchiveSuite ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
<<Anchor(CodeReViewTplOrColumns)>> '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
<<Anchor(CodeReViewTplOrColumns)>> '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.