~+'''Reviews in Iteration 40'''+~<<BR>> ~-Use IterationReviewsOverviewTemplate template to start new review pages.-~

Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~

<<Anchor(CodeReViewTplCrTable)>>  '''''Code Reviews'''''<<BR>> Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>> For details on how to do a code review, see [[Process/Code Review|Code Review Process]].  <<BR>> Code Reviews are done in the review-tool Crucible: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>> Template for insertion of a new line in edit mode: <<BR>> `|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Releasetest''' <<BR>> excl. or incl. TEST case.item and status ||<bgcolor="#dddddd" style="text-align: center;">'''Manuals''' <<BR>> Manual page(s)/chapter(s) ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-121|NS-121]] ||Bug 1705 ||JOLF ||SVC || 2009/11/19 || IssuesFromNs121 || N/A || N/A ||Run the installation scripts twice, and look for any ssh or scp errors. || N/A ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/NS-122|NS-122]] ||Bug 1736 ||JOLF ||HBK || 2009/12/10 || IssuesFromNs122 || JOLF || OK || Run a batchjob which takes more than one minute, and check that batchjob status entries has been placed in the log (can be seen through the 'System State'). || N/A ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/MG-3|MG-3]] || IT40 Task 48. Generic converter prototype ||HBK || SVC || 2009/11/26 || http://netarkivet.dk/suite/IssuesFromMG3 || HBK || OK || No release test || N/A ||
||[[http://kb-prod-udv-001.kb.dk:8060/cru/MG-5|MG-5]] || IT40 Task 53. WAF converter ||HBK || JOLF || 2009/12/04 || http://netarkivet.dk/suite/IssuesFromMG5 || HBK || OK || No release test || N/A ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-124|NS-124]] ||FR 1777 || SVC || HBK ||2009/12/01 || IssuesFromNs124 || SVC ||OK ||Make a urllist, and save this to a file. Make an eventharvest and add seeds to this harvest from this file. ||UserManual needs to modified: 2.3. Adding seeds to an event harvest ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-125|NS-125]] || Assignment B.2.2a || JOLF || HBK || 2009/12/10 || IssuesFromNs125 || JOLF || OK || Release test description sent to TLR. || Installation Manual and Additional Tools Manual. ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-126|NS-126]] ||FR 1757 || HBK || SVC || 2009/12/DD || IssuesFromNs126 || HBK || OK || Release test should also test this button. || Use documentation is updated. ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-129|NS-129]] ||Assignment B.2.2b || JOLF || SVC || 2009/12/11 || IssuesFromNs129 || JOLF || OK || N/A || N/A ||
|| [[http://kb-prod-udv-001.kb.dk:8060/cru/NS-130|NS-130]] ||Priority 5 bugs: 1833 and 1835  || JOLF || SVC || 2009/12/16 || IssuesFromNs130 || - || OK || N/A || N/A ||


<<Anchor(CodeReViewTplOrTable)>>   '''''Document Reviews'''''<<BR>>  Description of columns can be found in section [[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>> For details on how to other reviews, see [[Process/Document Review|Document Review Process]].<<BR>> Template for insertion of a new line in edit mode:<<BR>> `|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
|| [[DocumentReviewWaybackConfiguration|Configuration Manual 3.12/Wayback Configurations]] || 1 || 1-* || Bug 1796 || HBK ||SVC || 2009/11/23 || HBK || OK ||
|| [[DocumentReviewTaskOverviewNutchWAX|TaskOverviewNutchWAX]] || 1 || 1-* || -- || HBK || CSR || 2009/11/25 || HBK ||  OK ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||


<<Anchor(CodeReViewTplCrColumns)>> '''''Explanation of the columns in Code Review table:'''''

 * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is `[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]`
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.
 * "Release Test": Whether the changes are to be included in the Release test. Has values "'''-'''" if new, "'''incl.'''" if it is to be included in the release test and  "'''excl.'''" if it cannot be included in the release test (e.g. if not testable).
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel|Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel|Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel|Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel|Installation Manual]], "'''Dev.'''" for [[Developer Manual devel|Developer Manual]], "'''User'''" for [[User Manual devel|User Manual]].
<<Anchor(CodeReViewTplOrColumns)>>  '''''Explanation of the columns in Document Review table:'''''

 * "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
 * "Version": The SVN, CVS or date for revision of document/script to be reviewed.
 * "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
 * "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
 * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
 * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
 * "Review date": Date for review.
 * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
 * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed.