Iteration41ReviewsOverview - NetarchiveSuite

Reviews in Iteration 41
Use IterationReviewsOverviewTemplate template to start new review pages.

Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description

Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table.
For details on how to do a code review, see Code Review Process.
Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode:
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||

Review Id NS-XX	Task Bug/FR XXX	Author(s) INIT	Reviewer(s) INIT	Review date YYYY/MM/DD	Issues found IssuesFromNsXX	Follow-up INIT	Done -, OK, OK-wp	Releasetest excl. or incl. TEST case.item and status	Manuals Manual page(s)/chapter(s)
NS-131	FR 1846	JOLF	HBK	2010/01/15	IssuesFromNs131	JOLF	OK	Try adding a bitpreservation databasedir to the admin machine.	Installation Manual section 3.2.1 and 4.2.1.
NS-132	Bug 1844	HBK	SVC	2010/01/21	IssuesFromNs132	HBK	OK	No test needed	-
NS-133	Bug 1845	HBK	SVC	2010/01/21	IssuesFromNs133	HBK	OK	No test needed	-
NS-134	Bug 1834	JOLF	HBK	2010/01/15	IssuesFromNs134	JOLF	OK	Change the checksum file and correct them without restart.	-
NS-135	Bug 1836	JOLF	HBK	2010/01/15	IssuesFromNs135	JOLF	OK	N/A	-
NS-136	FR 1790	HBK	JOLF	2010/01/26	IssuesFromNs136	HBK	OK	Confirmed by running RunNetarchiveSuite.sh without parameters.	-
NS-137	Bug 1832	JOLF	CSR	2010/01/22	IssuesFromNs137	N/A	OK	Test by running setup with a checksum replica. Perform a harvest an check that the upload time to the checksum replica is less than 1 min.	-
NS-138	Bug 1727 and 1764	JOLF	SVC	2010/02/04	IssuesFromNs138	JOLF	OK	Release test 11 + run a batchjob from a jar file, which does not contain the batchjob method.	-
NS-140	FR 1861	HBK	JOLF	2010/01/26	IssuesFromNs140	HBK	OK	Should be confirmed in GUI	-
NS-141	--	HBK	SVC	2010/01/21	IssuesFromNs141	HBK	OK	No test needed	-
NS-142	FR 1578	HBK	CSR	YYYY/MM/DD	IssuesFromNs142	CSR	OK	Introduced settings instead of constant	-
NS-143	FR 1116	CSR	SVC	YYYY/MM/DD	IssuesFromNs143	CSR	OK	Required	User Manual Section 6
NS-144	FR 1580	HBK	CSR	YYYY/MM/DD	IssuesFromNs144	HBK	OK	Start standalone app with -v or --version	-
NS-145	FR 1823 and Assignment B.2.2b	JOLF	SVC	2010/02/08	IssuesFromNs145	JOLF	OK	Try sending a GetAllFilenamesMessage, a GetAllChecksumsMessage and a GetChecksumMessage to the bamon (default through the bitpreservation page). In the log of the bamon it should say "replying to converted batchjob".	Perhaps System Design?
MG-8	Task 52 IT 41	HBK	SVC	2010/01/26	IssuesFromMg8	HBK	OK	None	-
NS-146	Miscellaneous refactoring	SVC	JOLF	2010/02/08	IssuesFromNs146	SVC	OK	Change releasetest to use new package name for HarvestTemplateApplication	Additional tools
NS-139	Updated netarkivet.css so it is consistent in its style.	HBK	SVC	2010/02/08	IssuesFromNs139	HBK	OK	-	-

Document Reviews
Description of columns can be found in section Explanation of the columns in Document Review table.
For details on how to other reviews, see Document Review Process.
Template for insertion of a new line in edit mode:
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||

Document `[:link:docName]`	Version X.Y/date	Lines/parts All/x-y	Task Bug/FR XXX	Author(s) INIT	Reviewer(s) INIT	Review date YYYY/MM/DD	Follow-up INIT	Done -, OK, OK-wp
DocName	Version	Lines	Bug/FR XXX	INIT	INIT	YYYY/MM/DD	INIT	-

Explanation of the columns in Code Review table:

"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.

Explanation of the columns in Document Review table:

"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
"Version": The SVN, CVS or date for revision of document/script to be reviewed.
"Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.