Differences between revisions 33 and 34
Revision 33 as of 2009-03-02 13:00:39
Size: 6244
Editor: EldZierau
Comment:
Revision 34 as of 2010-08-16 10:25:11
Size: 6269
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 1: Line 1:
~+'''Reviews in Iteration <XX>'''+~[[BR]] ~+'''Reviews in Iteration <XX>'''+~<<BR>>
Line 4: Line 4:
Contains: ~-[#CodeReViewTplCrTable Code Review Table]-~, ~-[#CodeReViewTplOrTable Document Review Table]-~, ~-[#CodeReViewTplCrColumns Code Review Column Description]-~, ~-[#CodeReViewTplOrColumns Document Review Column Description]-~ Contains: ~-[[#CodeReViewTplCrTable|Code Review Table]]-~, ~-[[#CodeReViewTplOrTable|Document Review Table]]-~, ~-[[#CodeReViewTplCrColumns|Code Review Column Description]]-~, ~-[[#CodeReViewTplOrColumns|Document Review Column Description]]-~
Line 6: Line 6:
[[Anchor(CodeReViewTplCrTable)]]
'''''Code Reviews'''''[[BR]]
Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]. [[BR]]
For details on how to do a code review, see [:Process/Code_Review:Code Review Process]. [[BR]]
Code Reviews are done in the review-tool Crucible:
[http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] [[BR]]
Template for insertion of a new line in edit mode: [[BR]]
<<Anchor(CodeReViewTplCrTable)>>
'''''Code Reviews'''''<<BR>>
Description of columns can be found in section [[#CodeReViewTplCrColumns|Explanation of the columns in Code Review table]]. <<BR>>
For details on how to do a code review, see [[Process/Code Review|Code Review Process]]. <<BR>>
Code Reviews are done in the review-tool Crucible
: [[http://kb-prod-udv-001.kb.dk:8060/|Link to Crucible]], export is done via [[http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export|Crucible export function]] <<BR>>
Template for insertion of a new line in edit mode: <<BR>>
Line 14: Line 14:
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' [[BR]] ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' [[BR]] ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ || ||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' <<BR>> ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' <<BR>> ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
Line 17: Line 17:
[[Anchor(CodeReViewTplOrTable)]]
'''''Document Reviews'''''[[BR]]
Description of columns can be found in section
[#CodeReViewTplOrColumns Explanation of the columns in Document Review table].[[BR]]
For details on how to other reviews, see [:Process/Document_Review:Document Review Process]
.[[BR]]
Template for insertion of a new line in edit mode:[[BR]]
<<Anchor(CodeReViewTplOrTable)>>
'''''Document Reviews'''''<<BR>>
Description of columns can be found in section
[[#CodeReViewTplOrColumns|Explanation of the columns in Document Review table]].<<BR>>
For details on how to other reviews, see
[[Process/Document Review|Document Review Process]].<<BR>>
Template for insertion of a new line in edit mode:<<BR>>
Line 23: Line 23:
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' <<BR>> ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' <<BR>> ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' <<BR>> ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' <<BR>> ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''<<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' <<BR>> ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' <<BR>> ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' <<BR>> ~--, OK, OK-wp-~ ||
|| [[DocumentReview/DocNameIdReview|DocName]] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
Line 26: Line 26:
[[Anchor(CodeReViewTplCrColumns)]] <<Anchor(CodeReViewTplCrColumns)>>
Line 37: Line 37:
 * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [:Quick Start Manual devel: Quick Start Manual], "'''Deploy'''" for [:Deploy Manual devel: Deploy Manual], "'''Conf.'''" for [:Configuration Manual devel: Configuration Manual], "'''Inst..'''" for [:Installation Manual devel: Installation Manual], "'''Dev.'''" for [:Developer Manual devel: Developer Manual], "'''User'''" for [:User Manual devel: User Manual].  * "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "'''-'''" if new, "'''Quick'''" for [[Quick Start Manual devel| Quick Start Manual]], "'''Deploy'''" for [[Deploy Manual devel| Deploy Manual]], "'''Conf.'''" for [[Configuration Manual devel| Configuration Manual]], "'''Inst..'''" for [[Installation Manual devel| Installation Manual]], "'''Dev.'''" for [[Developer Manual devel| Developer Manual]], "'''User'''" for [[User Manual devel| User Manual]].
Line 39: Line 39:
[[Anchor(CodeReViewTplOrColumns)]] <<Anchor(CodeReViewTplOrColumns)>>

Reviews in Iteration <XX>
Use IterationReviewsOverviewTemplate template to start new review pages.

Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description

Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table.
For details on how to do a code review, see Code Review Process.
Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode:
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||

Review Id
NS-XX

Task
Bug/FR XXX

Author(s)
INIT

Reviewer(s)
INIT

Review date
YYYY/MM/DD

Issues found
IssuesFromNsXX

Follow-up
INIT

Done
-, OK, OK-wp

NS-XX

Bug/FR XXX

INIT

INIT

YYYY/MM/DD

IssuesFromNsXX

INIT

-

Document Reviews
Description of columns can be found in section Explanation of the columns in Document Review table.
For details on how to other reviews, see Document Review Process.
Template for insertion of a new line in edit mode:
|| [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||

Document
[:link:docName]

Version
X.Y/date

Lines/parts
All/x-y

Task
Bug/FR XXX

Author(s)
INIT

Reviewer(s)
INIT

Review date
YYYY/MM/DD

Follow-up
INIT

Done
-, OK, OK-wp

DocName

Version

Lines

Bug/FR XXX

INIT

INIT

YYYY/MM/DD

INIT

-

Explanation of the columns in Code Review table:

  • "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]

  • "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
  • "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
  • "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
  • "Review date": Date for review.
  • "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
  • "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
  • "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

  • "Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).

  • "Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.

Explanation of the columns in Document Review table:

  • "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].

  • "Version": The SVN, CVS or date for revision of document/script to be reviewed.
  • "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
  • "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
  • "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
  • "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
  • "Review date": Date for review.
  • "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
  • "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

IterationReviewsOverviewTemplate (last edited 2010-08-16 10:25:11 by localhost)