Diff for "IterationReviewsOverviewTemplate"

Differences between revisions 12 and 13

Reviews in Iteration <XX>

Contains: [#CodeReViewTplTemplates Templates], [#CodeReViewTplColumns Column description], [#CodeReViewTplCrLinks Code Review links and remarks], [#CodeReViewTplCrTable Code Review table], [#CodeReViewTplOrLinks Other Review links and remarks], [#CodeReViewTplOrTable Other Review table]

Anchor(CodeReViewTplTemplates) Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]

Anchor(CodeReViewTplColumns) Explanation of the columns:

"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally on form NS-XX
"Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
"Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
"Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
"Review date": Date for review.
"Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
"Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

Anchor(CodeReViewTplCrLinks) Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable time frame, another reviewer should be chosen.

Implementation time including coding, documentation and review is noted under information on issues found.

Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible]

Anchor(CodeReViewTplCrTable) For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].

Review Id NS-XX	Task BR Bug/FR XXX	Author(s) INIT	Reviewer(s) INIT	Review date YYYY/MM/DD	Issues found IssuesFromNsXX	Follow-up INIT	Done BR -, OK, OK-wp
NS-XX	Bug/FR XXX	INIT	INIT	YYYY/MM/DD	IssuesFromNsXX	INIT	-

Anchor(CodeReViewTplOrTable) For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].

Anchor(CodeReViewTplOrLinks)

-  ⇤ ← Revision 12 as of 2008-12-19 12:53:06 → 
  Size: 3004
  Editor: EldZierau
  Comment:
+   ← Revision 13 as of 2008-12-19 12:54:37 → ⇥
  Size: 3008
  Editor: EldZierau
  Comment:
-Deletions are marked like this.
+Additions are marked like this.
 Line 5:
-[[Anchor(CodeReViewTplTemplates)]] 
Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]
+[[Anchor(CodeReViewTplTemplates)]]  Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]
-Line 8:
+Line 7:
-[[Anchor(CodeReViewTplColumns)]] 
Explanation of the columns:
+[[Anchor(CodeReViewTplColumns)]]  Explanation of the columns:
-Line 18:
+Line 17:
-[[Anchor(CodeReViewTplCrLinks)]]
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
+[[Anchor(CodeReViewTplCrLinks)]] Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
-Line 28:
+Line 25:
-[[Anchor(CodeReViewTplCrTable)]]
For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].
||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review Id''' ~-NS-XX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)''' ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' ~-INIT-~ ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' [[BR]] ~- -, OK, OK-wp-~ ||
+[[Anchor(CodeReViewTplCrTable)]] For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].
||<bgcolor="#dddddd" style="text-align: center;">'''Review Id''' ~-NS-XX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)''' ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' ~-IssuesFromNsXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
-Line 33:
+Line 29:
-[[Anchor(CodeReViewTplOrTable)]]
For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].
+[[Anchor(CodeReViewTplOrTable)]] For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].