NetarchiveSuite|
Size: 5220
Comment:
|
Size: 4703
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 39: | Line 39: |
| For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process]. [[BR]] Templete for insertion of a new line in edit mode: | For details on how to other reviews, see [:Process/Other_Review_WithTitle:Other Review Process]. [[BR]] Templete for insertion of a new line in edit mode: |
| Line 43: | Line 43: |
| || <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || - || |
Reviews in Iteration <XX>BR Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]
Contains: [#CodeReViewTplCrColumns Code Review Column Description], [#CodeReViewTplCrTable Code Review Table], [#CodeReViewTplOrColumns Other Review Column Description], [#CodeReViewTplOrTable Other Review Table]
Anchor(CodeReViewTplCrColumns) Explanation of the columns in code review table:
- "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally on form NS-XX
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
Anchor(CodeReViewTplCrTable) Code ReviewsBR For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].BR Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible]BR Templete for insertion of a new line in edit mode: || NS-XX || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - ||
Review Id NS-XX |
Task BR Bug/FR XXX |
Author(s) INIT |
Reviewer(s) INIT |
Review date YYYY/MM/DD |
Issues found IssuesFromNsXX |
Follow-up INIT |
Done BR -, OK, OK-wp |
NS-XX |
Bug/FR XXX |
INIT |
INIT |
YYYY/MM/DD |
IssuesFromNsXX |
INIT |
- |
Anchor(CodeReViewTplCrColumns) Explanation of the columns in code review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
Anchor(CodeReViewTplOrTable) Other ReviewsBR For details on how to other reviews, see [:Process/Other_Review_WithTitle:Other Review Process]. BR Templete for insertion of a new line in edit mode: || DocName || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||