NetarchiveSuite|
Size: 2302
Comment:
|
Size: 1818
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 10: | Line 10: |
| ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Class/Page]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Version]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Lines/parts]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Task]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Author(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Reviewer(s)]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Review date]''' ||<bgcolor="#dddddd">'''[:Code Review Process#TableFilledReviewsOverview:Follow-up]''' ||<bgcolor="#dddddd" style="text-align: center;">'''[:Code Review Process#TableFilledReviewsOverview:Done]''' || || <Link to code review page for class/JSP-page named with java path name, f.ex. dk.netarkivet.harvestdefinition.JobDAO> || <SVN version of code being reviewed> || <Lines/parts to review> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author of changes in code> || <Initials of reviewer in code review> || <Date that review was held on form YYYY/MM/DD> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> || |
||<bgcolor="#dddddd" style="text-align: center;">'''Crucible Review Id''' ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)''' ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' || || <Crucible Review Id linking to Crucible named NS-<id>> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author(s) of changes in code> || <Initials of reviewer(s) in code review> || <Date that review was held on form YYYY/MM/DD> || <Link to wiki page named IssuesFoundInNs<id> which will contain infomraion on issues found in review from Crucible> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> || |
Reviews in Iteration <XX>
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
If the reviewer for some reason cannot be contacted within a reasonable time frame, another reviewer should be chosen.
Implementation time including coding, documentation and review is noted under information on issues found.
For details on how to do a code review, see [:Process/Code_Review_WithTitle:Code Review Process].
Crucible Review Id |
Task |
Author(s) |
Reviewer(s) |
Review date |
Issues found |
Follow-up |
Done |
<Crucible Review Id linking to Crucible named NS-<id>> |
<Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> |
<Initials of author(s) of changes in code> |
<Initials of reviewer(s) in code review> |
<Date that review was held on form YYYY/MM/DD> |
<Link to wiki page named IssuesFoundInNs<id> which will contain infomraion on issues found in review from Crucible> |
<Initials of person to do follow-up on code review> |
<Must be either BR Ok (no further action), BR Ok w/postponed (no further action within this iteration, but includes postpones to be done later)> |
For details on how to other reviews, see [:Process/Other_Review_WithTitle:Code Review Process].