Differences between revisions 27 and 28
Revision 27 as of 2008-12-19 14:21:42
Size: 5172
Editor: EldZierau
Comment:
Revision 28 as of 2008-12-19 14:23:40
Size: 5182
Editor: EldZierau
Comment:
Deletions are marked like this. Additions are marked like this.
Line 23: Line 23:
[[Anchor(CodeReViewTplOrColumns)]]
'''''Explanation of the columns in code review table:'''''
[[Anchor(CodeReViewTplOrColumns)]] 
'''''Explanation of the columns in document review table:'''''
Line 34: Line 34:
[[Anchor(CodeReViewTplOrTable)]]
'''''Other Reviews'''''[[BR]]
For details on how to other reviews, see [:Process/Other Review WithTitle:Other Review Process]. [[BR]] Templete for insertion of a new line in edit mode: `|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
Line 35: Line 38:
[[Anchor(CodeReViewTplOrTable)]]
'''''Other Reviews'''''[[BR]]
For details on how to other reviews, see [:Process/Other_Review_WithTitle:Other Review Process]. [[BR]] Templete for insertion of a new line in edit mode:
`|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||`
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' [[BR]] ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||
Line 40: Line 40:
||<bgcolor="#dddddd" style="text-align: center;">'''Document''' ~-`[:link:docName]`-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Version''' [[BR]] ~-X.Y/date-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Lines/parts''' [[BR]] ~-All/x-y-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' [[BR]] ~-Bug/FR XXX-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)'''[[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' [[BR]] ~-YYYY/MM/DD-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' [[BR]] ~-INIT-~ ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' [[BR]] ~--, OK, OK-wp-~ ||

Reviews in Iteration <XX>BR Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]

Contains: [#CodeReViewTplCrColumns Code Review Column Description], [#CodeReViewTplCrTable Code Review Table], [#CodeReViewTplOrColumns Other Review Column Description], [#CodeReViewTplOrTable Other Review Table]

Anchor(CodeReViewTplCrColumns) Explanation of the columns in code review table:

  • "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]

  • "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
  • "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
  • "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
  • "Review date": Date for review.
  • "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
  • "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
  • "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

Anchor(CodeReViewTplCrTable) Code ReviewsBR For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].BR Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] BR Templete for insertion of a new line in edit mode: || NS-XX || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - ||

Review Id BR NS-XX

Task BR Bug/FR XXX

Author(s)BR INIT

Reviewer(s) BR INIT

Review date BR YYYY/MM/DD

Issues found BR IssuesFromNsXX

Follow-up BR INIT

Done BR -, OK, OK-wp

NS-XX

Bug/FR XXX

INIT

INIT

YYYY/MM/DD

IssuesFromNsXX

INIT

-

Anchor(CodeReViewTplOrColumns) Explanation of the columns in document review table:

  • "Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].

  • "Version": The SVN, CVS or date for revision of document/script to be reviewed.
  • "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
  • "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
  • "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
  • "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
  • "Review date": Date for review.
  • "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
  • "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

Anchor(CodeReViewTplOrTable) Other ReviewsBR For details on how to other reviews, see [:Process/Other Review WithTitle:Other Review Process]. BR Templete for insertion of a new line in edit mode: || [:DocumentReview/DocNameIdReview:DocName] ||  Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||

Document BR [:link:docName]

Version BR X.Y/date

Lines/parts BR All/x-y

Task BR Bug/FR XXX

Author(s)BR INIT

Reviewer(s) BR INIT

Review date BR YYYY/MM/DD

Follow-up BR INIT

Done BR -, OK, OK-wp

[:DocumentReview/DocNameIdReview:DocName]

Version

Lines

Bug/FR XXX

INIT

INIT

YYYY/MM/DD

INIT

-

IterationReviewsOverviewTemplate (last edited 2010-08-16 10:25:11 by localhost)