1818
Comment:
|
1852
|
Deletions are marked like this. | Additions are marked like this. |
Line 9: | Line 9: |
For details on how to do a code review, see [:Process/Code_Review_WithTitle:Code Review Process]. ||<bgcolor="#dddddd" style="text-align: center;">'''Crucible Review Id''' ||<bgcolor="#dddddd" style="text-align: center;">'''Task''' ||<bgcolor="#dddddd" style="text-align: center;">'''Author(s)''' ||<bgcolor="#dddddd" style="text-align: center;">'''Reviewer(s)''' ||<bgcolor="#dddddd" style="text-align: center;">'''Review date''' ||<bgcolor="#dddddd" style="text-align: center;">'''Issues found''' ||<bgcolor="#dddddd" style="text-align: center;">'''Follow-up''' ||<bgcolor="#dddddd" style="text-align: center;">'''Done''' || || <Crucible Review Id linking to Crucible named NS-<id>> || <Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> || <Initials of author(s) of changes in code> || <Initials of reviewer(s) in code review> || <Date that review was held on form YYYY/MM/DD> || <Link to wiki page named IssuesFoundInNs<id> which will contain infomraion on issues found in review from Crucible> || <Initials of person to do follow-up on code review> || <Must be either [[BR]] '''''Ok''''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> || |
For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process]. ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Crucible Review Id''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' || ||<Crucible Review Id linking to Crucible named NS-<id>> ||<Reference to task caused the code changes that are being reviewed as for example a bugs, a feature request or an assignment> ||<Initials of author(s) of changes in code> ||<Initials of reviewer(s) in code review> ||<Date that review was held on form YYYY/MM/DD> ||<Link to wiki page named IssuesFoundInNs<id> which will contain infomraion on issues found in review from Crucible> ||<Initials of person to do follow-up on code review> ||<Must be either [[BR]] '''''Ok''' (no further action), [[BR]] '''''Ok w/postponed''''' (no further action within this iteration, but includes postpones to be done later)> '' || bb || ff || ff || gg || mm ||hh ||gg ||hh|| |
Line 13: | Line 14: |
For details on how to other reviews, see [:Process/Other_Review_WithTitle:Code Review Process]. | For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process]. |
Reviews in Iteration <XX>
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
If the reviewer for some reason cannot be contacted within a reasonable time frame, another reviewer should be chosen.
Implementation time including coding, documentation and review is noted under information on issues found.
For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].
Crucible Review Id |
Task |
Author(s) |
Reviewer(s) |
Review date |
Issues found |
Follow-up |
Done |
Expected "=" to follow "Crucible" > |
Expected "=" to follow "Reference"
|
Expected "=" to follow "Initials"
|
Expected "=" to follow "Initials"
|
Expected "=" to follow "Date"
|
Expected "=" to follow "Link" which will contain infomraion on issues found in review from Crucible> |
Expected "=" to follow "Initials"
|
Expected "=" to follow "Must"
|
bb || ff || ff || gg || mm ||hh ||gg ||hh||
For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].