NetarchiveSuite|
Size: 1577
Comment:
|
Size: 2451
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 2: | Line 2: |
Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template] Explanation of the columns: * "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally on form NS-XX * "Task": The assignment or bug that the code has been updated for, e.g. Bug 1512. * "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI. * "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review. * "Review date": Date for review. * "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFoundInNsXX. * "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'. * "Done": whether the review follow-up has been done. Has value "'''-'''" if new, "'''OK'''" if all follow-ups are done, "'''OK-wp'''" (with postpones) if follow-ups are done with exceptions that have been postponed. |
|
| Line 9: | Line 23: |
| Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible] |
|
| Line 10: | Line 26: |
| ||'''Crucible Review Id''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' || ||> ||'''Expected "=" to follow "Reference"''' ||'''Expected "=" to follow "Initials"''' ||'''Expected "=" to follow "Initials"''' ||'''Expected "=" to follow "Date"''' ||which will contain infomraion on issues found in review from Crucible> ||'''Expected "=" to follow "Initials"''' ||'''hgf''' || ||vvxcv ||vcxvxc ||vxcvxc ||vxcvcx ||vxcvx ||vxcvx ||vxcvcx ||vxcvx || || || || || || || || || || ||NS-XX ||ff ||ff ||gg ||mm ||hh ||gg ||hh || ||NS-XX ||ff ||ff ||gg ||mm ||hh ||gg ||hh || |
||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review Id''' NS-XX ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Task''' Bug/FR/PTC/ASS XXX ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Author(s)''' INIT ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Reviewer(s)''' INIT ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Review date''' YYYY/MM/DD ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Issues found''' IssuesFoundInNsXX ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Follow-up''' INIT ||<bgcolor="#dddddd" style="TEXT-ALIGN: center">'''Done''' -, OK, OK-wp || || NS-XX || Bug/FR/PTC/ASS XXX || INIT || INIT || YYYY/MM/DD || IssuesFoundInNsXX || INIT || - || |
Reviews in Iteration <XX>
Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]
Explanation of the columns:
- "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally on form NS-XX
- "Task": The assignment or bug that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFoundInNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.
If the reviewer for some reason cannot be contacted within a reasonable time frame, another reviewer should be chosen.
Implementation time including coding, documentation and review is noted under information on issues found.
Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible]
For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].
Review Id NS-XX |
Task Bug/FR/PTC/ASS XXX |
Author(s) INIT |
Reviewer(s) INIT |
Review date YYYY/MM/DD |
Issues found IssuesFoundInNsXX |
Follow-up INIT |
Done -, OK, OK-wp |
NS-XX |
Bug/FR/PTC/ASS XXX |
INIT |
INIT |
YYYY/MM/DD |
IssuesFoundInNsXX |
INIT |
- |
For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].