Differences between revisions 8 and 9
Revision 8 as of 2008-12-19 12:36:15
Size: 2451
Editor: EldZierau
Comment:
Revision 9 as of 2008-12-19 12:46:50
Size: 2972
Editor: EldZierau
Comment:
Deletions are marked like this. Additions are marked like this.
Line 3: Line 3:
Contains: ~-[#CodeReViewTplTemplates Templates]-~, ~-[#CodeReViewTplColumns Column description]-~, ~-[#CodeReViewTplCrLinks Code Review links and remarks]-~, ~-[#CodeReViewTplCrTable Code Review table]-~, ~-[#CodeReViewTplOrLinks Other Review links and remarks]-~, ~-[#CodeReViewTplOrTable Other Review table]-~

[[Anchor(CodeReViewTplTemplates)]]
Line 5: Line 8:

[[Anchor(CodeReViewTplColumns)]]
Line 17: Line 19:
[[Anchor(CodeReViewTplCrLinks)]]
Line 25: Line 28:
[[Anchor(CodeReViewTplCrTable)]]
Line 29: Line 33:
[[Anchor(CodeReViewTplOrTable)]]
Line 30: Line 35:

[[Anchor(CodeReViewTplOrLinks)]]

Reviews in Iteration <XX>

Contains: [#CodeReViewTplTemplates Templates], [#CodeReViewTplColumns Column description], [#CodeReViewTplCrLinks Code Review links and remarks], [#CodeReViewTplCrTable Code Review table], [#CodeReViewTplOrLinks Other Review links and remarks], [#CodeReViewTplOrTable Other Review table]

Anchor(CodeReViewTplTemplates) Use this template to start new review pages: [:IterationReviewsOverviewTemplate:Template]

Anchor(CodeReViewTplColumns) Explanation of the columns:

  • "Review Id": The Crucible Review Id which the review is created under in Crucible. Normally on form NS-XX
  • "Task": The assignment or bug that the code has been updated for, e.g. Bug 1512.
  • "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
  • "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
  • "Review date": Date for review.
  • "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFoundInNsXX.
  • "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
  • "Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.

Anchor(CodeReViewTplCrLinks) Review of code should happen immediately after coding for a task or bug is done, so as little as possible is based on unreviewed code.

If the reviewer for some reason cannot be contacted within a reasonable time frame, another reviewer should be chosen.

Implementation time including coding, documentation and review is noted under information on issues found.

Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible]

Anchor(CodeReViewTplCrTable) For details on how to do a code review, see [:Process/Code Review WithTitle:Code Review Process].

Review Id NS-XX

Task Bug/FR/PTC/ASS XXX

Author(s) INIT

Reviewer(s) INIT

Review date YYYY/MM/DD

Issues found IssuesFoundInNsXX

Follow-up INIT

Done -, OK, OK-wp

NS-XX

Bug/FR/PTC/ASS XXX

INIT

INIT

YYYY/MM/DD

IssuesFoundInNsXX

INIT

-

Anchor(CodeReViewTplOrTable) For details on how to other reviews, see [:Process/Other Review WithTitle:Code Review Process].

Anchor(CodeReViewTplOrLinks)

IterationReviewsOverviewTemplate (last edited 2010-08-16 10:25:11 by localhost)