Differences between revisions 7 and 8
Revision 7 as of 2009-01-23 19:01:59
Size: 1299
Comment:
Revision 8 as of 2009-01-23 19:03:56
Size: 1299
Comment:
Deletions are marked like this. Additions are marked like this.
Line 10: Line 10:
{{{  {{{
Line 14: Line 14:
{{{  {{{
Line 25: Line 25:

|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 81-82 || Consider implementing this code without the successful boolean || Minor || NOTOK ||
Line 26: Line 30:
||'''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| 81-82 || Consider implementing this code without the successful boolean || Minor || NOTOK ||
Line 31: Line 34:
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' || 
|| General || The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method || NA || NOTOK || 
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' ||
|| General || The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method || NA || NOTOK ||
Line 37: Line 40:
|| General || Purely refactoring being done here || NA || NOTOK ||  || General || Purely refactoring being done here || NA || NOTOK ||

Review (KBDOMS-3): Test crucible

Author

Søren

Moderator

Søren

State

Review

Objectives

Test crucible

Summary

null

Total Time Used (Coding,Documentation,Review):

SVC: 0.5 MD
TLR: 1,0 MD

General comments:

Description

Classification

Status

SVC: 0.5 MD TLR: 1,0 MD

TimeUse

NOTOK

Lines

Description

Classification

Status

81-82

Consider implementing this code without the successful boolean

Minor

NOTOK

Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/archive/KbdomsArcWriter.java', revision 1.5

Comments on file 'projects/kbdoms/code/src/dk/kb/doms/utils/ThreadUtils.java', revision 1.3

Lines

Description

Classification

Status

General

The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method

NA

NOTOK

Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/erez/PyramidCmd.java', revision 1.58

Lines

Description

Classification

Status

General

Purely refactoring being done here

NA

NOTOK

Process/Other Review WithTitle (last edited 2010-08-16 10:24:43 by localhost)