NetarchiveSuite|
Size: 1299
Comment:
|
Size: 1293
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 10: | Line 10: |
| {{{ | {{{ |
| Line 14: | Line 14: |
| {{{ | {{{ |
| Line 24: | Line 24: |
| === Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/archive/KbdomsArcWriter.java', revision 1.5 === | |
| Line 25: | Line 26: |
| === Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/archive/KbdomsArcWriter.java', revision 1.5 === ||'''Lines''' || '''Description''' || '''Classification''' || '''Status''' || || 81-82 || Consider implementing this code without the successful boolean || Minor || NOTOK || |
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' || || 81-82 || Consider implementing this code without the successful boolean || Minor || NOTOK || |
| Line 31: | Line 31: |
| || '''Lines''' || '''Description''' || '''Classification''' || '''Status''' || || General || The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method || NA || NOTOK || |
|| '''Lines''' || '''Description''' || '''Classification''' || '''Status''' || || General || The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method || NA || NOTOK || |
| Line 37: | Line 37: |
| || General || Purely refactoring being done here || NA || NOTOK || | || General || Purely refactoring being done here || NA || NOTOK || |
Review (KBDOMS-3): Test crucible
Author |
Søren |
Moderator |
Søren |
State |
Review |
Objectives
Test crucible
Summary
null
Total Time Used (Coding,Documentation,Review):
SVC: 0.5 MD TLR: 1,0 MD
General comments:
Description |
Classification |
Status |
SVC: 0.5 MD TLR: 1,0 MD |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/archive/KbdomsArcWriter.java', revision 1.5
Lines |
Description |
Classification |
Status |
81-82 |
Consider implementing this code without the successful boolean |
Minor |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/utils/ThreadUtils.java', revision 1.3
Lines |
Description |
Classification |
Status |
General |
The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method |
NA |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/erez/PyramidCmd.java', revision 1.58
Lines |
Description |
Classification |
Status |
General |
Purely refactoring being done here |
NA |
NOTOK |