Review (KBDOMS-3): Test crucible
Author |
Søren |
Moderator |
Søren |
State |
Review |
Objectives
Test crucible
Summary
null
Total Time Used (Coding,Documentation,Review):
SVC: 0.5 MD TLR: 1,0 MD
General comments:
Description |
Classification |
Status |
SVC: 0.5 MD TLR: 1,0 MD |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/archive/KbdomsArcWriter.java', revision 1.5
Lines |
Description |
Classification |
Status |
81-82 |
Consider implementing this code without the successful boolean |
Minor |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/utils/ThreadUtils.java', revision 1.3
Lines |
Description |
Classification |
Status |
General |
The method waitForFileToAppear formerly existed in the class PyramidCmd as a private method |
NA |
NOTOK |
Comments on file 'projects/kbdoms/code/src/dk/kb/doms/components/erez/PyramidCmd.java', revision 1.58
Lines |
Description |
Classification |
Status |
General |
Purely refactoring being done here |
NA |
NOTOK |