Differences between revisions 2 and 3
Revision 2 as of 2009-03-12 16:22:07
Size: 1202
Comment:
Revision 3 as of 2009-03-13 07:59:08
Size: 1184
Comment:
Deletions are marked like this. Additions are marked like this.
Line 8: Line 8:
Line 11: Line 10:
{{{ 
Time use (Coding,Documentation,Review) 

{{{
Time use (Coding,Documentation,Review)
Line 16: Line 16:
Line 23: Line 22:
|| 115 || missing spaces between arguments || Cosmetic || NOTOK || || 115 || missing spaces between arguments || Cosmetic || OK ||
Line 26: Line 25:
|| 289 || Spelling: charcters || Cosmetic || NOTOK ||
|| 295 || Make consistent or explain why "{" is escaped and not "}"? || Minor || NOTOK ||
|| 288 || You probably meant: java.net.URI(String s) Adapt javadoc to liittle bit more precise || Cosmetic || NOTOK ||
|| 272 || Improperly named variable: Should be renamed to uriString || Cosmetic || NOTOK ||
|| 289 || Spelling: charcters || Cosmetic || OK ||
|| 295 || Make consistent or explain why "{" is escaped and not "}"? || Minor || OK
||
|| 288 || You probably meant: java.net.URI(String s) Adapt javadoc to liittle bit more precise || Cosmetic || OK ||
|| 272 || Improperly named variable: Should be renamed to uriString || Cosmetic || OK ||

Review (NS-16): Bugfix 1152

Author

Colin

Moderator

Colin

State

Closed

Objectives

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
CSR: 2 MD
SVC: 0.5 MD

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/ARCLookup.java', revision 584

Lines

Description

Classification

Status

115

missing spaces between arguments

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/viewerproxy/WebProxy.java', revision 584

Lines

Description

Classification

Status

289

Spelling: charcters

Cosmetic

OK

|| 295 || Make consistent or explain why "{" is escaped and not "}"? || Minor || OK ||

288

You probably meant: java.net.URI(String s) Adapt javadoc to liittle bit more precise

Cosmetic

OK

272

Improperly named variable: Should be renamed to uriString

Cosmetic

OK

IssuesFoundInReviewNs16 (last edited 2010-08-16 10:25:15 by localhost)