Differences between revisions 3 and 5 (spanning 2 versions)
⇤ ← Revision 3 as of 2009-04-23 13:43:18 →
Size: 1585
Editor: SoerenCarlsen
Comment:
← Revision 5 as of 2010-08-16 10:25:09 → ⇥
Size: 1570
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 15: Line 15:
Line 22: Line 23:

Line 24: Line 27:
|| General || All methods starting with "abstract protected" need to start with "protected abstract" instead. See http://checkstyle.sourceforge.net/config_modifier.html || Cosmetic || NOTOK ||
|| 411, 415 || Cut and paste error. Should write: Problems creating " + Constants.JMX_FILE_NAME + ": " + e || Cosmetic || NOTOK ||
|| 525 || "under monitor" => for the monitor || Cosmetic || NOTOK ||
|| 616 || "hetrix" => Heritrix || Cosmetic || NOTOK ||
|| 617 || The Heritrix role is 'readwrite', not readonly. || Cosmetic || NOTOK ||
|| 630, 643-644 || Refer to heritrix role, not monitor.jmxUsername || Cosmetic || NOTOK ||		 || General || All methods starting with "abstract protected" need to start with "protected abstract" instead. See http://checkstyle.sourceforge.net/config_modifier.html || Cosmetic || OK ||
|| 411, 415 || Cut and paste error. Should write: Problems creating " + Constants.JMX_FILE_NAME + ": " + e || Cosmetic || OK ||
|| 525 || "under monitor" => for the monitor || Cosmetic || OK ||
|| 616 || "hetrix" => Heritrix || Cosmetic || OK ||
|| 617 || The Heritrix role is 'readwrite', not readonly. || Cosmetic || OK ||
|| 630, 643-644 || Refer to heritrix role, not monitor.jmxUsername || Cosmetic || OK ||
Line 32: Line 35:
|| 201, 203 || rename as JMXREMOTE*_PRIVILEGES || Cosmetic || NOTOK || || 201, 203 || rename as JMXREMOTE*_PRIVILEGES || Cosmetic || OK ||

Review (NS-41): Bug 1613: Only monitorRole and controlRole works as JMX usernames

Author

Søren

Moderator

Søren

State

Closed

Objectives

Verify the fix for bug 1613.
Includes changes to deploy, and changes to JMXHeritrixController

Summary

Follow up by JOLF

Total Time Used (Coding,Documentation,Review): 

Time use (Coding,Documentation,Review)
SVC:  0.5
JOLF: 1.0

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/deploy/Machine.java', revision 803

Lines

Description

Classification

Status

General

All methods starting with "abstract protected" need to start with "protected abstract" instead. See http://checkstyle.sourceforge.net/config_modifier.html

Cosmetic

OK

411, 415

Cut and paste error. Should write: Problems creating " + Constants.JMX_FILE_NAME + ": " + e

Cosmetic

OK

525

"under monitor" => for the monitor

Cosmetic

OK

616

"hetrix" => Heritrix

Cosmetic

OK

617

The Heritrix role is 'readwrite', not readonly.

Cosmetic

OK

630, 643-644

Refer to heritrix role, not monitor.jmxUsername

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/deploy/ScriptConstants.java', revision 803

Lines

Description

Classification

Status

201, 203

rename as JMXREMOTE*_PRIVILEGES

Cosmetic

OK

IssuesFoundInReviewNs41 (last edited 2010-08-16 10:25:09 by localhost)