Differences between revisions 1 and 3 (spanning 2 versions)

Review (NS-42): Review of bug 1564 (again) and 1629

Author	Søren
Moderator	Søren
State	Closed

Objectives

Review of code changes necessary to fix bug 1564 and 1629:
Comprises changes to
1)  /trunk/src/dk/netarkivet/archive/ArchiveSettings.java (revision 812):
2)  /trunk/src/dk/netarkivet/archive/bitarchive/BitarchiveAdmin.java (revision 812)
3)  /trunk/src/dk/netarkivet/archive/settings.xml (revision 812)

Summary

kfc to followup

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/BitarchiveAdmin.java', revision 812

Lines	Description	Classification	Status
197	change to log.warn	Cosmetic	OK

Comments on file 'trunk/src/dk/netarkivet/archive/ArchiveSettings.java', revision 812

Lines	Description	Classification	Status
85	Is it ok with final as modifier here; The other settings does not have this modifier This is wrong; the final must be removed	Minor	OK

-  ⇤ ← Revision 1 as of 2009-04-30 09:30:55 → 
  Size: 1172
  Editor: SoerenCarlsen
  Comment:
+   ← Revision 3 as of 2010-08-16 10:24:43 → ⇥
  Size: 1170
  Editor: localhost
  Comment: converted to 1.6 markup
-Deletions are marked like this.
+Additions are marked like this.
 Line 19:
-Line 21:
+Line 23:
-|| 197 || change to log.warn || Cosmetic || NOTOK ||
+|| 197 || change to log.warn || Cosmetic || OK ||
-Line 24:
+Line 26:
-|| 85 || Is it  ok with final as modifier here; The other settings does not have this modifier This is wrong; the final must be removed || Minor || NOTOK ||
+|| 85 || Is it  ok with final as modifier here; The other settings does not have this modifier This is wrong; the final must be removed || Minor || OK ||