NetarchiveSuite
Review (NS-124): FR 1777, and changes by upgrade to fileupload 1.2.1 (a lot of old classes have been deprecated)
Author |
Søren |
Moderator |
Søren |
State |
Closed |
Objectives
This FR actually adds a new way of adding seeds to an eventharvest, ie. from a file.
Summary
Review completed; follow up by SVC
Total Time Used (Coding,Documentation,Review):
Time use (Coding,Documentation,Review) HBK: 0.5 md SVC: 4 md
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/webpages/HarvestDefinition/Definitions-ingest-domains.jsp', revision 1156
Lines |
Description |
Classification |
Status |
67 |
Add . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
70 |
Add . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
71 |
Need a space before these two lines. |
Cosmetic |
OK |
73 |
Add space before and '.' after. |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/harvester/webinterface/EventHarvest.java', revision 1163
Lines |
Description |
Classification |
Status |
135 |
Change '@param context@param context' to '@param context'. Add . |
Cosmetic |
OK |
144 |
Add '.' end of sentence in this comment block. |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
151 |
Why not check ordertemplate isn't null here? |
Cosmetic |
OK |
165 |
Enter ind the middle of confuguration. |
Cosmetic |
NOTOK |
172 |
Missing . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
179 |
Move block above reading file. No need to read file into memory if ordertemplate is null. |
Minor |
NOTOK |
181 |
Missing . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
195 |
Add '.' in the above two lines. |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
203 |
Use HTMLUtils.parseOptionalLong instead of this method? HTMLUtils.parseObtionalLong(context, maxbyteString, deafultMaxBytes)? |
Minor |
OK |
Comments on file 'trunk/src/dk/netarkivet/harvester/Translations_fr.properties', revision 1156
Lines |
Description |
Classification |
Status |
23 |
Add . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
Comments on file 'trunk/webpages/HarvestDefinition/Definitions-upload-harvest-template.jsp', revision 1156
Lines |
Description |
Classification |
Status |
73 |
Spaces before and '.' after comments in the above 4 lines. |
Cosmetic |
OK |
Comments on file 'trunk/webpages/HarvestDefinition/Definitions-add-event-seeds.jsp', revision 1163
Lines |
Description |
Classification |
Status |
77 |
missing . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
87 |
missing . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
89 |
missing . |
Cosmetic |
REJECTED (Not required to have periods at end of line in non-java doc comments) |
92 |
Line too long. |
Cosmetic |
OK |
96 |
Indention. |
Cosmetic |
OK |
152 |
Indention in this block seems wrong. |
Cosmetic |
OK |