Review (NS-134): Bug 1834: Synchronize memory archive with file archive

Author

Jonas

Moderator

Jonas

State

Closed

Objectives

Ensure that whenever an external accesses the checksum file the synchronization is performed.
Also, whenever the checksum file is changed the 'lastModifiedChecksumFile' is updated to reflect this change.

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
JOLF: 0.4
HBK: 0.1

General comments:

Description

Classification

Status

Comments on file 'trunk/src/dk/netarkivet/archive/checksum/FileChecksumArchive.java', revision 1207

Lines

Description

Classification

Status

159

Shouldn't this argument be "int minSpaceLeft"? And couldn't this check we replaced with ArgumentNotValid.checkPositive, even though this is a private constructor?

Cosmetic

OK

517

the checksum file?

Cosmetic

OK

801

This should be logged as a warning, not info.

Cosmetic

OK

IssuesFromNs134 (last edited 2010-08-16 10:24:38 by localhost)