Review (NS-46): Review of Bug 1694: LocalArcRepositoryClient is broken Fixes the ARCReader constructor call.

Author

Søren

Moderator

Søren

State

Closed

Objectives

/trunk/src/dk/netarkivet/common/distribute/arcrepository/LocalArcRepositoryClient.java, revision 838, lines 147-148

Summary

Followup by Nicolas Giraud

Total Time Used (Coding,Documentation,Review):

Time use (Coding,Documentation,Review)
NGiraud: 0.25
SVC: 0

General comments:

Description

Classification

Status

File does not end with a new line: Add new line after EOF

Cosmetic

OK

add a unittest for the get() method

Cosmetic

OK

Comments on file 'trunk/src/dk/netarkivet/common/distribute/arcrepository/LocalArcRepositoryClient.java', revision 838

Lines

Description

Classification

Status

148

remove tab from line

Cosmetic

OK

148

remove unused line

Cosmetic

OK

IssuesFromNs46 (last edited 2010-08-16 10:24:38 by localhost)