NetarchiveSuite
Review (NS-83): Bug 555: JMS Connection reconnect
Author |
Kåre |
Moderator |
Kåre |
State |
Closed |
Objectives
Code updated to do exception handling on all JMSExceptions where it seems reasonable. Also: Much better synchronization when reconnecting.
Summary
KFC follows up
Total Time Used (Coding,Documentation,Review):
Time used: KFC: 2md SVC: 1md
General comments:
Description |
Classification |
Status |
Comments on file 'trunk/src/dk/netarkivet/common/distribute/JMSConnectionSunMQ.java', revision 964
Lines |
Description |
Classification |
Status |
197 |
This is unneccessary synchronization |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/common/distribute/JMSConnection.java', revision 963
Lines |
Description |
Classification |
Status |
|| General || Sanity test by killing and starting JMS connection in TEST system || Minor || (OK)Done locally not to disturb TEST system ||
62 |
I've noticed some variety in how the Log is created in NetarchiveSuite. We currently use besides getLog(TheNameOfTheClass.class) also getLog(getClass()), and getLog(getClass().getName(), and getLog(TheNameOfTheclass.class.getName()). This should probably be standardized. |
Cosmetic |
POSTPONED |
87 |
It may be possible to use just one session, and then simplify code further |
Cosmetic |
OK |
240 |
Consider deprecating reply, and using only specialised reply messages. Post an FR on this |
Minor |
OK |
624-625 |
Shouldn't the log message be after the call to onException(e)? This is seen in other methods as well. |
Cosmetic |
OK |
Comments on file 'trunk/src/dk/netarkivet/archive/bitarchive/distribute/BatchReplyMessage.java', revision 963
Lines |
Description |
Classification |
Status |
62-63 |
Add that filesFailed may be null |
Cosmetic |
OK |