Reviews in Iteration 39
Use IterationReviewsOverviewTemplate template to start new review pages.
Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description
Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table.
For details on how to do a code review, see Code Review Process.
Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode:
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||
Review Id |
Task |
Author(s) |
Reviewer(s) |
Review date |
Issues found |
Follow-up |
Done |
Releasetest |
Manuals |
Bug 1705 |
JOLF |
HBK |
2009/10/21 |
JOLF |
OK |
Run the installation scripts twice, and look for any ssh or scp errors. |
No |
||
FR 1745 |
JOLF |
HBK |
2009/10/21 |
JOLF |
OK |
Run Deploy with a configuration file where the environment name is set to 'E*R_R?O=R'. It should fail. |
Installation manual (add to limitations) |
||
FR 1751 |
JOLF |
HBK |
2009/10/21 |
JOLF |
OK |
On a running installation, run the local 'restart' script on some machines and verify that the bitapps restart in the System overview without any errors |
Installation manual. |
||
FR 1733 |
JOLF |
HBK |
2009/10/21 |
No issues. |
N/A |
OK |
Run a batchjob, which reads system properties. It should be allowed. Need more info here.... |
Perhaps Additional Tools Manual. |
|
FR 1765 |
Nicolas |
SVC |
2009/10/19 |
Nicolas |
OK |
- |
- |
||
Bug 1771 |
SVC |
HBK |
2009/10/21 |
- |
OK |
- |
- |
||
Bug 749 |
HBK |
SVC |
2009/10/20 |
HBK |
OK |
TEST5 item 6 |
- |
||
Bug 1758 |
CSR |
HBK |
2009/10/20 |
CSR |
OK |
- |
- |
||
FR 1776 |
Andreas |
CSR |
2009/10/23 |
No issues. |
N/A |
OK |
- |
Configuration Manual 3.10 |
|
Changes from work on Assignment B2.2 |
JOLF |
SVC |
2009/10/23 |
JOLF |
OK |
These changes are tested in current selected tests. |
Not yet. |
||
Assignment 2.3 |
HBK |
CSR |
2009/10/?? |
HBK |
OK |
- |
- |
||
Bug 1712 |
KFC |
SVC |
2009/10/22 |
- |
OK |
Not possible |
None needed |
||
Added logging to startup notice concerning where the bitarchive |
HBK |
JOLF |
2009/10/22 |
HBK |
OK |
None |
None |
||
Bug 1770 |
KFC |
SVC |
2009/10/23 |
- |
OK |
None |
None |
||
FR 1759 a.o |
SVC |
HBK |
2009/10/23 |
SVC |
OK |
|
|
||
FR 1773 |
CSR |
SVC |
2009/10/30 |
CSR |
OK |
|
User Manual |
||
Assigment 2.3 test |
HBK |
JOLF |
2009/10/26 |
HBK |
OK |
None |
Quickstart |
||
Wayback deply |
HBK |
CSR |
2009/??/?? |
HBK |
OK |
Test12 |
|
||
Bug 1786 |
SVC |
JOLF |
2009/10/28 |
SVC |
OK |
|
|
||
FR 1687 French translation |
Nicolas |
CSR |
2009/10/28 |
Nicolas |
OK |
|
|
||
Bug 1793 |
KFC |
SVC |
2009/11/11 |
- |
OK |
|
System design, section 'Settings' |
Document Reviews
Description of columns can be found in section Explanation of the columns in Document Review table.
For details on how to other reviews, see Document Review Process.
Template for insertion of a new line in edit mode:
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
Document |
Version |
Lines/parts |
Task |
Author(s) |
Reviewer(s) |
Review date |
Follow-up |
Done |
Version |
Lines |
Bug/FR XXX |
INIT |
INIT |
YYYY/MM/DD |
INIT |
- |
Explanation of the columns in Code Review table:
"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.
Reviews in Iteration 39
Use IterationReviewsOverviewTemplate template to start new review pages.
Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description
Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table.
For details on how to do a code review, see Code Review Process.
Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode:
|| [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||
Review Id |
Task |
Author(s) |
Reviewer(s) |
Review date |
Issues found |
Follow-up |
Done |
Releasetest |
Manuals |
Document Reviews
Description of columns can be found in section Explanation of the columns in Document Review table.
For details on how to other reviews, see Document Review Process.
Template for insertion of a new line in edit mode:
|| [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - ||
Document |
Version |
Lines/parts |
Task |
Author(s) |
Reviewer(s) |
Review date |
Follow-up |
Done |
Version |
Lines |
Bug/FR XXX |
INIT |
INIT |
YYYY/MM/DD |
INIT |
- |
|
Version |
Lines |
Assignment B.2.2a - Generalise replica to include all checksum voters |
JOLF |
|
|
|
Installation Manual: update of deploy config xml's ;System Design Manual 5. Detailed Archive Design Description; User Manual 10. System State ?,11. Bit Preservation; Additional Tools Manual: 5.6. dk.netarkivet.archive.tools.RunBatch |
|
Version |
Lines |
How to verify Bug 1547 |
TLR |
|
|
|
Installation Manual: 10.3. How to add a harvester more on the same machine and set all to HIGHPRIORITY selective harvesting |
|
Version |
Lines |
New deploy for Quickstart |
TLR |
|
|
|
Quick Start Manual Configuration, Viewing the results ; Installation Manual 10. Easy Installation of NetarchiveSuite |
Explanation of the columns in Code Review table:
"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.
Explanation of the columns in Document Review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
Explanation of the columns in Document Review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.