Reviews in Iteration 36BR Use IterationReviewsOverviewTemplate template to start new review pages.
Contains: [#CodeReViewTplCrTable Code Review Table], [#CodeReViewTplOrTable Document Review Table], [#CodeReViewTplCrColumns Code Review Column Description], [#CodeReViewTplOrColumns Document Review Column Description]
Anchor(CodeReViewTplCrTable) Code ReviewsBR Description of columns can be found in section [#CodeReViewTplCrColumns Explanation of the columns in Code Review table]
For details on how to do a code review, see [:Process/Code Review:Code Review Process].
Code Reviews are done in the review-tool Crucible: [http://kb-prod-udv-001.kb.dk:8060/ Link to Crucible], export is done via [http://kb-prod-udv-001.kb.dk:8060/plugins/servlet/export Crucible export function] BR Template for insertion of a new line in edit mode: || [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||
Review Id BR NS-XX |
Task BR Bug/FR XXX |
Author(s)BR INIT |
Reviewer(s) BR INIT |
Review date BR YYYY/MM/DD |
Issues found BR IssuesFromNsXX |
Follow-up BR INIT |
Done BR -, OK, OK-wp |
Release Test BR -, incl., excl. |
Manuals BR Quick, Deploy, Conf., Inst., Dev., User |
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-12 NS-12] |
Java 6 (FileUtils.GetBytesFree() |
KFC |
JOLF/SVC |
2009/02/24 |
IssuesFoundInReviewNs12 |
SVC |
OK |
|
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-17 NS-17] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=662 Bug 662] |
CSR |
SVC |
2009/03/10 |
IssuesFoundInReviewNs17 |
CSR |
OK-wp |
incl.+ |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-16 NS-16] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1152 Bug 1152] |
CSR |
SVC |
2009/02/20 |
IssuesFoundInReviewNs16 |
CSR |
OK |
incl.+ |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-19 NS-19] |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=934&group_id=7&atid=105 Bug 934] |
SVC |
JOLF |
2009/2/19 |
IssuesFoundInReviewNs19 |
SVC |
OK |
incl.? |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-32 NS-32] |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1492&group_id=7&atid=105 Bug 1492], [https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1410 FR 1410] |
ELZI |
|
|
[:IssuesFoundInReviewNs19:IssuesFoundInReviewNsXX] |
- |
- |
incl.? |
User |
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-34 NS-34] |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=574&group_id=7&atid=105 Bug 574] |
ELZI |
|
|
[:IssuesFoundInReviewNs19:IssuesFoundInReviewNsXX] |
- |
- |
incl.? |
|
|
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1193&group_id=7&atid=105 Bug 1193] |
SVC |
JOLF |
|
[:IssuesFoundInReviewNs19:IssuesFoundInReviewNsXX] |
- |
- |
incl.? |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-23 NS-23] |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1497&group_id=7&atid=108 FR 1497 (Button in NetarchiveSuite)] |
SVC |
JOLF |
2009/03/10 |
IssuesFoundInReviewNs23 |
SVC |
OK |
incl.+ |
User |
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-20 NS-20] |
[:AssignmentDeploy1:Deploy Assignment 1] - module [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=431&group_id=7&atid=105 Bug 431], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=433&group_id=7&atid=105 Bug 433], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=846&group_id=7&atid=105 Bug 846], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1271&group_id=7&atid=105 Bug 1271], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1520&group_id=7&atid=108 FR 1520] |
JOLF |
SVC |
2009/02/18 |
IssuesFoundInReviewsNs20 |
JOLF |
OK? |
incl.? |
Install,Deploy,Config |
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-33 NS-33] |
[:AssignmentDeploy1:Deploy Assignment 1] - settings, [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=291&group_id=7&atid=108 FR 291], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1488&group_id=7&atid=108 FR 1488], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1308&group_id=7&atid=105 Bug 1308], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105 Bug 1501] |
ELZI |
|
2009/X/Y |
[:IssuesFoundInReviewNs25:IssuesFoundInReviewNsXX] |
- |
- |
incl.? |
Install, Deploy,Config |
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-30 NS-30] |
[:AssignmentDeploy1:Deploy Assignment 1] - System state |
JOLF |
SVC |
2009/X/Y |
[:IssuesFoundInReviewNs25:IssuesFoundInReviewNs30] |
JOLF |
- |
incl.? |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-21 NS-21] |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1493&group_id=7&atid=107 Patch 1493 (German Translation)] |
SVC |
JOLF |
2009/03/10 |
IssuesFoundInReviewNs21 |
SVC |
OK |
excl. |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-22 NS-22] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1336 Bug 1336] |
CSR |
SVC |
2009/02/20 |
IssuesFoundInReviewNs22 |
CSR |
OK |
excl. |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-28] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=770 FR 770], [http://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1146 FR 1146], [https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1226 Bug 1226] |
SVC |
CSR |
|
[:IssuesFoundInReviewNs25:IssuesFoundInReviewNs28] |
|
|
incl.? |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-25 NS-29] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1160 FR 1160], [https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1162 FR 1162], |
SVC |
JOLF |
|
IssuesFoundInReviewNs25 |
|
|
incl.? |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-24 NS-24] |
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1485 FR 1485] |
SVC |
JOLF |
2009/03/11 |
IssuesFoundInReviewNs24 |
SVC |
OK |
incl.? |
|
|
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1519 Bug 1519] |
SVC |
JOLF |
|
[:IssuesFoundInReviewNs24:IssuesFoundInReviewNsXX] |
|
|
incl.+ |
|
[http://kb-prod-udv-001.kb.dk:8060/cru/NS-25 NS-25] |
Review of FileUtils.getResourceFileFromClassPath() |
JOLF |
SVC |
2009/02/25 |
IssuesFoundInReviewNs25 |
JOLF |
- |
- |
- |
|
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=108&func=detail&aid=1252 FR 1252] |
SVC |
|
|
|
|
|
incl.? |
|
|
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1266 Bug 1266] |
SVC |
|
|
|
|
|
incl.? |
|
|
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1564 Bug 1564] |
SVC |
|
|
|
|
|
incl.? |
|
|
[https://gforge.statsbiblioteket.dk/tracker/?group_id=7&atid=105&func=detail&aid=1566 Bug 1566] |
SVC |
|
|
|
|
|
incl.? |
|
Anchor(CodeReViewTplOrTable) Document ReviewsBR Description of columns can be found in section [#CodeReViewTplOrColumns Explanation of the columns in document review table].
For details on how to do Document reviews, see [:Process/Document Review:Document Review Process].
Template for insertion of a new line in edit mode: || [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - || Template for new document review page (under DocumentReview/): ReviewDocumentPageTemplate
Document BR [:link:docName] |
Version BR X.Y/date |
Lines/parts BR All/x-y |
Task BR Bug/FR XXX |
Author(s)BR INIT |
Reviewer(s) BR INIT |
Review date BR YYYY/MM/DD |
Follow-up BR INIT |
Done BR -, OK, OK-wp |
[:DocumentReview/NetarchiveSuiteAssignmentDeploy1Review:http://netarchive.dk/suite/AssignmentDeploy1] |
2008/12/15 |
All |
|
ELZI |
SVC |
2008/12/16 |
ELZI |
OK-wp |
[:DocumentReview/NetarchiveSuiteAssignmentGroupB2Review:http://netarchive.dk/suite/AssignmentGroupB2] |
2008/10/30 |
All |
|
ELZI |
KFC |
2008/10/31 |
ELZI |
OK |
[:DocumentReview/NetarchiveSuiteQuickStartManualReview:https://netarchive.dk/suite/Quick_Start_Manual_devel] |
?? |
All |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1104&group_id=7&atid=108 FR 1104], new screen dumps |
TLR |
|
|
|
|
[:DocumentReview/NetarchiveSuiteConfigurationManualReview:https://netarchive.dk/suite/Configuration_Manual_devel] |
?? |
All |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1514&group_id=7&atid=105 Bug 1514] |
ELZI |
|
|
|
|
[:DocumentReview/NetarchiveSuiteInstallationManualReview:https://netarchive.dk/suite/Installation_Manual_devel] |
?? |
All |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1484&group_id=7&atid=105 Bug 1484], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1389&group_id=7&atid=108 FR 1389], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1104&group_id=7&atid=108 FR 1104], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=281&group_id=7&atid=108 FR 281], settings + [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1389&group_id=7&atid=108 FR 1226, ] [:AssignmentDeploy1:Deploy Assignment 1], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105 Bug 1501] |
ELZI/JOLF |
|
|
|
|
[:DocumentReview/NetarchiveSuiteDeveloperManualReview:https://netarchive.dk/suite/Developer_Manual_devel] |
?? |
All |
structure ([https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1287&group_id=7&atid=108 FR 1287]) batch ([https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1216&group_id=7&atid=105 Bug 1216]), upload, channels ([https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1132&group_id=7&atid=105 Bug 1132]) deduplication (task 44 in [:Iteration36TaskList:Iteration 36]) |
ELZI/SVC |
CSR |
2009/03/18 |
|
|
http://netarchive.dk/suite /Deploy_Manual_devel (integrated into the Installation Manual) |
?? |
All |
[:AssignmentDeploy1:Deploy Assignment 1], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1501&group_id=7&atid=105 Bug 1501] |
JOLF |
|
|
|
|
[:DocumentReview/NetarchiveSuiteUserManualReview:https://netarchive.dk/suite/User_Manual_devel] |
?? |
All |
[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1178&group_id=7&atid=105 Bug 1178], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1266&group_id=7&atid=105 Bug 1266], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1178&group_id=7&atid=105 Bug 1178], new screen dumps, Files with checksumserrors, Missing files,Harvest information for job, [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1212&group_id=7&atid=105 Bug 1212], [https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1261&group_id=7&atid=105 Bug 1261],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1262&group_id=7&atid=105 Bug 11262],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1263&group_id=7&atid=105 Bug 1263],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1266&group_id=7&atid=105 Bug 1266],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1108&group_id=7&atid=108 FR 1108],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1497&group_id=7&atid=105 Bug 1497],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1492&group_id=7&atid=105 Bug 1492],[https://gforge.statsbiblioteket.dk/tracker/index.php?func=detail&aid=1410&group_id=7&atid=105 Bug 1410] |
CLO |
|
|
|
|
[:DocumentReview/NetarchiveSuiteBugInfGuideReview:http://netarchive.dk/suite/BugInfGuide] |
2009/02/10 |
All |
Task 2+3 in [:Iteration36TaskList:Iteration 36] |
ELZI |
|
|
|
|
Anchor(CodeReViewTplCrColumns) Explanation of the columns in Code Review table:
"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for [:Quick Start Manual devel:Quick Start Manual], "Deploy" for [:Deploy Manual devel:Deploy Manual], "Conf." for [:Configuration Manual devel:Configuration Manual], "Inst.." for [:Installation Manual devel:Installation Manual], "Dev." for [:Developer Manual devel:Developer Manual], "User" for [:User Manual devel:User Manual].
Anchor(CodeReViewTplOrColumns) Explanation of the columns in Document Review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.