Reviews in Iteration 36
Use IterationReviewsOverviewTemplate template to start new review pages.
Contains: Code Review Table, Document Review Table, Code Review Column Description, Document Review Column Description
Code Reviews
Description of columns can be found in section Explanation of the columns in Code Review table
For details on how to do a code review, see Code Review Process.
Code Reviews are done in the review-tool Crucible: Link to Crucible, export is done via Crucible export function
Template for insertion of a new line in edit mode: || [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX] || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || IssuesFromNsXX || INIT || - || - || - ||
Review Id |
Task |
Author(s) |
Reviewer(s) |
Review date |
Issues found |
Follow-up |
Done |
Release Test |
Manuals |
Java 6 (FileUtils.GetBytesFree() |
KFC |
JOLF/SVC |
2009/02/24 |
SVC |
OK |
Excl |
Quick |
||
CSR |
SVC |
2009/03/10 |
CSR |
OK-wp |
incl.TEST4 item18.1 ok |
|
|||
CSR |
SVC |
2009/02/20 |
CSR |
OK |
incl. TEST4 item 15-16 ok |
|
|||
SVC |
JOLF |
2009/2/19 |
SVC |
OK |
incl.TEST1 item2 ok |
|
|||
ELZI |
JOLF |
2009/03/25 |
ELZI |
OK-wp |
incl. TEST3 item7 ok |
|
|||
ELZI |
SVC |
2009/03/25 |
ELZI |
OK-wp |
incl. in other tests (hard to test separately) |
|
|||
Bug 1193, Batch Framework |
SVC |
JOLF |
2009/03/24 |
SVC |
OK-wp |
incl.TEST11 item3 ok |
|
||
SVC |
JOLF |
2009/03/10 |
SVC |
OK |
incl.TEST2 item13 ok |
User |
|||
Deploy Assignment 1 - module Bug 431, Bug 433, Bug 846, Bug 1271, FR 1520 |
JOLF |
SVC |
2009/02/18 |
JOLF |
OK |
incl.TEST3 ok |
|
||
Deploy Assignment 1 - settings, FR 291, FR 1488, Bug 1308, Bug 1501 |
ELZI |
JOLF |
2009/03/25 |
ELZI |
OK |
incl.TEST1 item2 ok |
Quick, User, Install, Config |
||
Additional to NS-33 |
ELZI |
JOLF |
2009/03/25 |
ELZI |
OK-wp |
incl.TEST1 item2 ok |
Quick, User, Install, Config |
||
Additional to NS-33 |
ELZI |
SVC |
2009/03/25 |
SVC |
OK |
incl.TEST1 item2 ok |
Quick, User, Install, Config |
||
Deploy Assignment 1 - System state |
JOLF |
SVC |
2009/03/17 |
JOLF |
OK |
incl.TEST1 ok |
|
||
SVC |
JOLF |
2009/03/10 |
SVC |
OK |
excl. |
|
|||
CSR |
SVC |
2009/02/20 |
CSR |
OK |
excl. |
|
|||
SVC |
CSR |
2009/03/19 |
SVC |
OK |
incl.TEST1 item 6, TEST7 item 2-2.0(1226) |
|
|||
SVC |
JOLF |
2009/03/20 |
SVC |
OK |
incl.TEST7 item 5 |
|
|||
SVC |
JOLF |
2009/03/11 |
SVC |
OK |
incl.TEST1 item6 ok |
|
|||
SVC |
JOLF |
2009/03/20 |
SVC |
OK-wp |
incl.TEST4 item6 ok |
|
|||
Review of FileUtils.getResourceFileFromClassPath() |
JOLF |
SVC |
2009/02/25 |
JOLF |
OK |
- |
- |
||
NA (no code changes) |
FR 1252(Derby Upgrade) |
SVC |
|
|
|
|
|
incl.TEST7 item 2-2.0 |
Install |
No code changes |
ELZI |
|
|
|
|
|
|
User |
|
SVC |
JOLF |
2009/03/19 |
SVC |
OK |
incl.TEST12 |
|
|||
SVC |
JOLF |
2009/04/16 |
SVC |
OK |
incl.TEST? |
|
|||
SVC/JOLF |
JOLF |
2009/04/23 |
JOLF |
OK |
incl.TEST1 |
|
|||
KFC |
SVC |
2009/04/30 |
KFC |
OK |
incl. TEST12 |
|
|||
CSR |
SVC |
2009/05/11 |
CSR |
OK |
- |
- |
Document Reviews
Description of columns can be found in section Explanation of the columns in document review table.
For details on how to do Document reviews, see Document Review Process.
Template for insertion of a new line in edit mode: || [:DocumentReview/DocNameIdReview:DocName] || Version || Lines || Bug/FR XXX || INIT || INIT || YYYY/MM/DD || INIT || - || Template for new document review page (under DocumentReview/): ReviewDocumentPageTemplate
Document |
Version |
Lines/parts |
Task |
Author(s) |
Reviewer(s) |
Review date |
Follow-up |
Done |
2008/12/15 |
All |
|
ELZI |
SVC |
2008/12/16 |
ELZI |
OK-wp |
|
2008/10/30 |
All |
|
ELZI |
KFC |
2008/10/31 |
ELZI |
OK |
|
?? |
All |
FR 1104, new screen dumps |
TLR |
|
|
|
|
|
?? |
All |
ELZI |
|
|
|
|
||
?? |
All |
Bug 1484, FR 1389, FR 1104, FR 281, settings + FR 1226, Deploy Assignment 1, Bug 1501, Bug 1266 |
ELZI/JOLF |
|
|
|
|
|
?? |
All |
structure (FR 1287) batch (Bug 1216), upload, channels (Bug 1132) deduplication (task 44 in Iteration 36) |
ELZI/SVC |
CSR |
2009/03/18 |
CSR/JOLF/SVC/ELZI |
|
|
http://netarchive.dk/suite /Deploy_Manual_devel (integrated into the Installation Manual) |
?? |
All |
JOLF |
|
|
|
|
|
?? |
All |
Bug 1178, Bug 1266, Bug 1178, new screen dumps, Files with checksumserrors, Missing files,Harvest information for job, Bug 1212, Bug 1261,Bug 11262,Bug 1263,Bug 1266,FR 1108,Bug 1497,Bug 1492,Bug 1410 |
CLO |
|
|
|
|
|
2009/02/10 |
All |
Task 2+3 in Iteration 36 |
ELZI |
|
|
|
|
Explanation of the columns in Code Review table:
"Review Id": The Crucible Review Id which the review is created under in Crucible. Normally name is on form NS-XX, i.e. text to be inserted is [http://kb-prod-udv-001.kb.dk:8060/cru/NS-XX NS-XX]
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Issues found": Link to wiki page with issues found under review (and mandays of work). Normally on form IssuesFromNsXX.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.
"Release Test": Whether the changes are to be included in the Release test. Has values "-" if new, "incl." if it is to be included in the release test and "excl." if it cannot be included in the release test (e.g. if not testable).
"Manuals": The manuals that has to be/is updated as a concequence of the change. Has values "-" if new, "Quick" for Quick Start Manual, "Deploy" for Deploy Manual, "Conf." for Configuration Manual, "Inst.." for Installation Manual, "Dev." for Developer Manual, "User" for User Manual.
Explanation of the columns in Document Review table:
"Document": Link to issue review page for document named with identification of the document, e.g. http://netarchive.dk/suite/AssignmentDeploy1 - See example in [Iteration 36].
- "Version": The SVN, CVS or date for revision of document/script to be reviewed.
- "Parts/lines": Specifies the parts of the document/script to review (if less that the whole file).
- "Task": The assignment or tracker issue that the code has been updated for, e.g. Bug 1512.
- "Author(s)": The person(s) who have made changes or additions to the code. Only Initials are given, e.g. ELZI.
- "Reviewer(s)": The person(s) who have not been involved in coding these changes, who will participate in the review.
- "Review date": Date for review.
- "Follow-up": The person who will do the follow-up on the review specified under 'Issues found'.
"Done": whether the review follow-up has been done. Has value "-" if new, "OK" if all follow-ups are done, "OK-wp" (with postpones) if follow-ups are done with exceptions that have been postponed.